69541[PoC][WIP][TASK] Extbase PSR-7 Request
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 3
Review log 34
-
Christian Kuhn uploaded patch set 1 06/22/21, 14:33
-
core-ci voted on patch set 1 V -1 06/22/21, 14:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12668
-
Christian Kuhn commented on patch set 1 06/22/21, 14:56
If we rename ExtbaseRequestDecorator to (existing) Mvc/Request and implement the missing setters into both the decorator channelling everything to the attribute, this would be fully transparent, not breaking, and we don't need to munge with ServerRequest $request itself since the extbase specific stuff is encapsulated in the attribute. Extbase RequestInterface could extend ServerRequestInterface without problems, we don't need to re-pack from one request object to another and there is close to none additional deprecated code and extesion dev's don't need to do anything. -
Christian Kuhn abandoned the change 06/23/21, 16:20