69542[BUGFIX] Fix dashboard error when event is not initialized
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetSelector.ts+5 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Dashboard/DashboardModuleCest.phpnew+101 −0
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php3+10 −7
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html2+4 −4
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetSelector.js+1 −1
Review log 1826
Show 1 earlier messages
-
Jochen Roth uploaded patch set 1 06/22/21, 15:11
-
Jochen Roth commented on patch set 1 06/22/21, 15:12
Can you please check if it is ok to replace the href value with # in Main.html ? Not sure if it causes any unexpected side effects. Thank you. -
core-ci voted on patch set 1 V -1 06/22/21, 15:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12671
-
Chris Müller commented on patch set 1 06/22/21, 15:28
DashboardController.php:207UnresolvedIs it wise to use an exception from another package (Extbase)? Also, should be not also an exception code used? -
Jochen Roth uploaded patch set 2 06/23/21, 08:00
-
core-ci voted on patch set 2 V -1 06/23/21, 08:11 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12687
-
Jochen Roth uploaded patch set 3 06/23/21, 09:17
-
core-ci voted on patch set 3 V +1 06/23/21, 09:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12688
-
Jochen Roth uploaded patch set 4 06/28/21, 19:14
-
core-ci voted on patch set 4 V +1 06/28/21, 19:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12781
-
Oli Bartsch commented on patch set 4 06/29/21, 09:24
DashboardController.php:206This more or less duplicates the check already present in L:210 and will furthermore not prevent the undefined array key warning in L:204.Main.html:66If this link does not longer contain a target, it's a button. Same for L:76. -
Jochen Roth uploaded patch set 5 06/30/21, 17:31
-
core-ci voted on patch set 5 V +1 06/30/21, 17:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12864
-
Jochen Roth commented on patch set 5 V +1 CR +1 06/30/21, 17:46
DashboardController.php:206ReplyDoneMain.html:66ReplyDone -
Jochen Roth wrote 06/30/21, 17:46
Removed Verified+1 by Jochen <rothjochen@gmail.com> -
Jochen Roth wrote 06/30/21, 17:46
Removed Code-Review+1 by Jochen <rothjochen@gmail.com> -
Oli Bartsch uploaded patch set 6 07/01/21, 09:09
-
core-ci voted on patch set 6 V +1 07/01/21, 09:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12889
-
Oli Bartsch voted on patch set 6 V +1 CR +1 07/01/21, 10:06
-
Jochen Roth uploaded patch set 7 07/01/21, 12:20
-
core-ci voted on patch set 7 V +1 07/01/21, 12:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12895
-
Benni Mack updated the commit message in patch set 8 07/01/21, 13:08
-
Oli Bartsch commented on patch set 8 V +1 CR +1 07/01/21, 13:15
Tests are now also working locally on mac 👍 -
core-ci voted on patch set 8 V +1 07/01/21, 13:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12898
-
Benni Mack voted on patch set 8 V +2 CR +2 07/05/21, 10:00
-
Benni Mack merged patch set 9 07/05/21, 10:00