69545[FEATURE] Extbase Request implements ServerRequestInterface
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/master/Feature-94428-ExtbaseRequestImplementsServerRequestInterface.rstnew+40 −0
- typo3/sysext/extbase/Classes/Mvc/Web/ReferringRequest.php+6 −10
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+12 −11
- typo3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php8new+483 −0
- typo3/sysext/extbase/Classes/Mvc/Request.php8+538 −321
- typo3/sysext/extbase/Classes/Mvc/RequestInterface.php+115 −36
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php5+1 −32
- phpstan.neon+5 −0
Review log 1728
Show 23 earlier messages
-
Christian Kuhn uploaded patch set 1 06/23/21, 16:20
-
core-ci voted on patch set 1 V -1 06/23/21, 16:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12696
-
Christian Kuhn uploaded patch set 2 06/23/21, 17:00
-
core-ci voted on patch set 2 V -1 06/23/21, 19:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12698
-
Christian Kuhn uploaded patch set 3 06/24/21, 14:50
-
core-ci voted on patch set 3 V -1 06/24/21, 14:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12710
-
Christian Kuhn uploaded patch set 4 06/24/21, 17:41
-
core-ci voted on patch set 4 V -1 06/24/21, 17:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12719
-
core-ci commented on patch set 4 06/24/21, 18:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12719
-
Christian Kuhn uploaded patch set 5 06/25/21, 11:47
-
core-ci voted on patch set 5 V -1 06/25/21, 11:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12731
-
Christian Kuhn uploaded patch set 6 06/25/21, 11:58
-
core-ci voted on patch set 6 V +1 06/25/21, 12:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12732
-
Christian Kuhn uploaded patch set 7 06/28/21, 14:33
-
core-ci voted on patch set 7 V +1 06/28/21, 14:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12774
-
Christian Kuhn uploaded patch set 8 06/29/21, 08:50
-
core-ci voted on patch set 8 V +1 06/29/21, 09:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12789
-
Oli Bartsch commented on patch set 8 06/29/21, 10:30
ExtbaseRequestParameters.php:491This method is unused and also does not seem to make sense here.ExtbaseRequestParameters.php:504This method is unused as it's now implemented twice, here and in the Mvc/Request.ExtbaseRequestParameters.php:521This method is unused as it's now implemented twice, here and in the Mvc/Request.Request.php:36Something missing here?Request.php:51Is there a reason to not create a "real" object using the factory here?Request.php:58Is there a reason to not create a "real" object using the factory here?RequestTest.php:40Why do we remove this test? Exception is still thrown.RequestTest.php:75Why do we remove this test? Does this functionality not longer exist? -
Christian Kuhn commented on patch set 8 06/29/21, 11:03
ExtbaseRequestParameters.php:1Replyyes. but not now. Breaks to much, would make the patch far too huge.ExtbaseRequestParameters.php:491Replytrue - forgot about this one. thx.ExtbaseRequestParameters.php:504Replytrue. can be dropped here.ExtbaseRequestParameters.php:521Replytrue. can be dropped here.Request.php:36Replyhaha. nice.Request.php:51ReplyI'd say that's a fallback that will vanish (soon) anyways, it's pretty much core-internal when there is no TYPO3_REQUEST at all (just install tool). Imho ok'ish enough to work with an empty object for now.Request.php:58ReplyI'd say that's a fallback that will vanish (soon) anyways, it's pretty much core-internal when there is no TYPO3_REQUEST at all (just install tool). Imho ok'ish enough to work with an empty object for now.RequestTest.php:40ReplyOn ExtbaseRequestParameters: public function setArgument(string $argumentName, $value): self so int is not allowed anymore and the empty string scenario is tested belowe.RequestTest.php:75Replyit's ugly and does not make much sense. setArgument() is tested without mock with various other scenarios already. -
Christian Kuhn uploaded patch set 9 06/29/21, 11:03
-
core-ci voted on patch set 9 V -1 06/29/21, 11:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12796
-
Christian Kuhn uploaded patch set 10 06/29/21, 11:18
-
core-ci voted on patch set 10 V +1 06/29/21, 11:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12797
-
Oli Bartsch commented on patch set 10 06/29/21, 11:32
Request.php:51ReplyGot the "will vanish soon" part, therefore it's not that important to me in this case. Generally, I still think a factory should be preferred over new() - as soon as such exist. Especially because we could simply use the static ServerRequestFactory::fromGlobals() here.RequestTest.php:75ReplyActually this does not test setArgument(), but setArguments(). However, I'm fine with removing it for now as this does not really test setArguments() functionality, but only ensures setArgument() is called internally. -
Oli Bartsch voted on patch set 10 V +1 CR +1 06/29/21, 13:34
-
Benni Mack voted on patch set 10 V +2 CR +2 06/30/21, 13:28
-
Benni Mack merged patch set 11 06/30/21, 13:28
-
Benjamin Franzke commented on patch set 11 10/01/21, 08:32
Request.php:86UnresolvedI think this is misleading as it's not the original server request, please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/71396 which cleans that up
ExtbaseRequestParameters.php:1