69550[FEATURE] Make recordlist export configurable
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/RecordExportButton.tsnew+106 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-94411-RecordlistExportSettings.rstnew+48 −0
- typo3/sysext/core/Tests/Acceptance/Backend/RecordList/RecordExportCest.phpnew+65 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −0
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+1 −0
- typo3/sysext/recordlist/Classes/Controller/InvalidTableException.phpdeleted+0 −27
- typo3/sysext/recordlist/Classes/Controller/RecordExportController.php7+292 −51
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php4+26 −10
- typo3/sysext/recordlist/Classes/RecordList/ExportRecordList.phprenamed+22 −12
- typo3/sysext/recordlist/Configuration/Backend/AjaxRoutes.php+4 −0
- typo3/sysext/recordlist/Configuration/Backend/Routes.php+2 −1
- typo3/sysext/recordlist/Resources/Private/Language/locallang_export.xlf+98 −2
- typo3/sysext/recordlist/Resources/Private/Templates/RecordExportSettings.htmlnew+84 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/RecordExportButton.jsnew+13 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/ExportRecordListTest.phprenamed+75 −8
Review log 2437
Show 712 earlier messages
-
Oli Bartsch uploaded patch set 1 06/24/21, 23:46
-
core-ci voted on patch set 1 V -1 06/24/21, 23:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12722
-
Oli Bartsch uploaded patch set 2 06/25/21, 00:10
-
core-ci voted on patch set 2 V +1 06/25/21, 00:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12723
-
Benni Mack uploaded patch set 3 06/25/21, 10:31
-
core-ci voted on patch set 3 V +1 06/25/21, 10:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12730
-
Oli Bartsch uploaded patch set 4 06/25/21, 13:07
-
Oli Bartsch uploaded patch set 5 06/25/21, 13:13
-
Oli Bartsch uploaded patch set 6 06/25/21, 13:16
-
core-ci voted on patch set 4 V +1 06/25/21, 13:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12735
-
Oli Bartsch uploaded patch set 7 06/25/21, 13:18
-
core-ci voted on patch set 5 V +1 06/25/21, 13:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12736
-
core-ci voted on patch set 6 V +1 06/25/21, 13:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12738
-
core-ci voted on patch set 7 V +1 06/25/21, 13:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12739
-
Oli Bartsch uploaded patch set 8 06/25/21, 14:05
-
core-ci voted on patch set 8 V +1 06/25/21, 14:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12740
-
Oli Bartsch uploaded patch set 9 06/25/21, 15:07
-
core-ci voted on patch set 9 V +1 06/25/21, 15:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12745
-
Benni Mack commented on patch set 9 06/25/21, 17:15
RecordExportController.php:186How about: Adding the table, id, search_levels etc as query parameters to the form? Then you don't need the hidden fields in the Fluid template.DatabaseRecordList.php:791would change this title to "Export Page: 23 Record", not mentioning the "Configuration". Also, about naming: I think - all of these are Export settings, not actual configuration.DatabaseRecordList.php:796this should be moved in the controller(s) (also check RecordSelector, where the button is also shown). -
Oli Bartsch uploaded patch set 10 06/28/21, 09:38
-
Oli Bartsch commented on patch set 10 06/28/21, 09:39
RecordExport.ts:34ReplyDoneRecordExportController.php:186ReplyActually this is intended. Since the export action is POST only, IMO just parsed body should be consider there.DatabaseRecordList.php:791ReplyDoneDatabaseRecordList.php:796ReplyDone -
Oli Bartsch uploaded patch set 11 06/28/21, 09:43
-
core-ci voted on patch set 10 V +1 06/28/21, 09:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12770
-
core-ci voted on patch set 11 V +1 06/28/21, 09:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12771
-
Benni Mack voted on patch set 11 V +1 CR +1 06/28/21, 11:36
-
Oli Bartsch commented on patch set 11 06/29/21, 10:32
RecordExportController.php:186ReplyDone -
Christian Kuhn commented on patch set 11 CR -1 06/29/21, 13:37
on it. -
Christian Kuhn commented on patch set 11 06/29/21, 15:36
RecordExportController.php:104should be \RuntimeException - this can't happen regularily.RecordExportController.php:108should be \RuntimeException - this can't happen regularily. -
Oli Bartsch uploaded patch set 12 06/29/21, 15:45
-
Oli Bartsch commented on patch set 12 06/29/21, 15:47
RecordExportController.php:104ReplyDoneRecordExportController.php:108ReplyDone -
Christian Kuhn voted on patch set 12 V +1 CR +1 06/29/21, 15:52
-
core-ci voted on patch set 12 V -1 06/29/21, 15:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12805
-
Christian Kuhn rebased onto patch set 13 06/29/21, 15:57
-
core-ci voted on patch set 13 V +1 06/29/21, 16:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12806
-
Christian Kuhn voted on patch set 13 V +1 CR +1 06/29/21, 16:15
-
Benni Mack voted on patch set 13 V +2 CR +2 06/29/21, 18:05
-
Benni Mack merged patch set 14 06/29/21, 18:05
RecordExport.ts:34