Review main Merged

69550[FEATURE] Make recordlist export configurable

Oli Bartsch CR +2 V +2 Hard +838 −111 updated 06/29/21, 18:05

Commit message

This adds a new modal to the recordlist export functionality,
allowing users to configure export settings such as format,
filename, selected columns / all columns and raw values /
processed values. Also some options, depending on the
chosen format, are configurable (e.g. delimiter for CSV).

To make the format selection useful and to further improve
the exisiting export functionality, JSON is added as another
possible export format.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 2437

Show 712 earlier messages
  1. Oli Bartsch uploaded patch set 1 06/24/21, 23:46

  2. core-ci voted on patch set 1 V -1 06/24/21, 23:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12722

  3. Oli Bartsch uploaded patch set 2 06/25/21, 00:10

  4. core-ci voted on patch set 2 V +1 06/25/21, 00:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12723

  5. Benni Mack uploaded patch set 3 06/25/21, 10:31

  6. core-ci voted on patch set 3 V +1 06/25/21, 10:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12730

  7. Oli Bartsch uploaded patch set 4 06/25/21, 13:07

  8. Oli Bartsch uploaded patch set 5 06/25/21, 13:13

  9. Oli Bartsch uploaded patch set 6 06/25/21, 13:16

  10. core-ci voted on patch set 4 V +1 06/25/21, 13:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12735

  11. Oli Bartsch uploaded patch set 7 06/25/21, 13:18

  12. core-ci voted on patch set 5 V +1 06/25/21, 13:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12736

  1. core-ci voted on patch set 6 V +1 06/25/21, 13:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12738

  2. core-ci voted on patch set 7 V +1 06/25/21, 13:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12739

  3. Oli Bartsch uploaded patch set 8 06/25/21, 14:05

  4. core-ci voted on patch set 8 V +1 06/25/21, 14:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12740

  5. Oli Bartsch uploaded patch set 9 06/25/21, 15:07

  6. core-ci voted on patch set 9 V +1 06/25/21, 15:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12745

  7. Benni Mack commented on patch set 9 06/25/21, 17:15

    RecordExport.ts:34

    wouldn't this be a record-export-button?

    RecordExportController.php:186

    How about: Adding the table, id, search_levels etc as query parameters to the form? Then you don't need the hidden fields in the Fluid template.

    DatabaseRecordList.php:791

    would change this title to "Export Page: 23 Record", not mentioning the "Configuration". Also, about naming: I think - all of these are Export settings, not actual configuration.

    DatabaseRecordList.php:796

    this should be moved in the controller(s) (also check RecordSelector, where the button is also shown).
  8. Oli Bartsch uploaded patch set 10 06/28/21, 09:38

  9. Oli Bartsch commented on patch set 10 06/28/21, 09:39

    RecordExport.ts:34 Reply

    Done

    RecordExportController.php:186 Reply

    Actually this is intended. Since the export action is POST only, IMO just parsed body should be consider there.

    DatabaseRecordList.php:791 Reply

    Done

    DatabaseRecordList.php:796 Reply

    Done
  10. Oli Bartsch uploaded patch set 11 06/28/21, 09:43

  11. core-ci voted on patch set 10 V +1 06/28/21, 09:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12770

  12. core-ci voted on patch set 11 V +1 06/28/21, 09:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12771

  13. Benni Mack voted on patch set 11 V +1 CR +1 06/28/21, 11:36

  14. Oli Bartsch commented on patch set 11 06/29/21, 10:32

    RecordExportController.php:186 Reply

    Done
  15. Christian Kuhn commented on patch set 11 CR -1 06/29/21, 13:37

    on it.
  16. Christian Kuhn commented on patch set 11 06/29/21, 15:36

    RecordExportController.php:104

    should be \RuntimeException - this can't happen regularily.

    RecordExportController.php:108

    should be \RuntimeException - this can't happen regularily.
  17. Oli Bartsch uploaded patch set 12 06/29/21, 15:45

  18. Oli Bartsch commented on patch set 12 06/29/21, 15:47

    RecordExportController.php:104 Reply

    Done

    RecordExportController.php:108 Reply

    Done
  19. Christian Kuhn voted on patch set 12 V +1 CR +1 06/29/21, 15:52

  20. core-ci voted on patch set 12 V -1 06/29/21, 15:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12805

  21. Christian Kuhn rebased onto patch set 13 06/29/21, 15:57

  22. core-ci voted on patch set 13 V +1 06/29/21, 16:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12806

  23. Christian Kuhn voted on patch set 13 V +1 CR +1 06/29/21, 16:15

  24. Benni Mack voted on patch set 13 V +2 CR +2 06/29/21, 18:05

  25. Benni Mack merged patch set 14 06/29/21, 18:05