Review main Merged

69551[TASK] Use runtime cache for LanguageService

Benni Mack CR +2 V +2 Normal +73 −76 updated 06/28/21, 08:34

Commit message

This change moves state for caching purposes
from $GLOBALS[LANG] into the runtime cache
allowing for further reducing the need to keep
the LanguageService in a global state.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 914

  1. Benni Mack uploaded patch set 1 06/25/21, 07:33

  2. core-ci voted on patch set 1 V -1 06/25/21, 07:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12727

  3. Benjamin Franzke uploaded patch set 2 06/25/21, 14:43

  4. Benjamin Franzke uploaded patch set 3 06/25/21, 14:47

  5. core-ci voted on patch set 2 V -1 06/25/21, 14:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12742

  6. core-ci voted on patch set 3 V -1 06/25/21, 14:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12744

  7. Benjamin Franzke uploaded patch set 4 06/25/21, 17:34

  8. core-ci voted on patch set 4 V +1 06/25/21, 17:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12751

  9. Benjamin Franzke voted on patch set 4 V +1 CR +1 06/26/21, 08:18

  10. Christian Kuhn rebased onto patch set 5 06/28/21, 08:15

  11. core-ci voted on patch set 5 V +1 06/28/21, 08:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12768

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 06/28/21, 08:29

  13. Benjamin Franzke voted on patch set 5 V +2 CR +2 06/28/21, 08:34

  14. Benjamin Franzke merged patch set 6 06/28/21, 08:34