69575[BUGFIX] Undefined key warning in table wizard for PHP8
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Jochen Roth uploaded patch set 1 06/25/21, 15:50
-
core-ci voted on patch set 1 V -1 06/25/21, 16:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12748
-
Jochen Roth commented on patch set 1 06/25/21, 16:38
> Patch Set 1: Verified-1 > > Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12748 First we need to merge: https://github.com/TYPO3/styleguide/pull/217 and update the styleguide extension. -
Jochen Roth uploaded patch set 2 06/28/21, 20:35
-
core-ci voted on patch set 2 V -1 06/28/21, 20:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12784
-
Oli Bartsch commented on patch set 2 06/29/21, 09:32
TableController.php:284What do you think about (int)($row[$this->colsFieldName] ?? 0) instead? IMO easier to read.TableController.php:287This is change in behaviour. Previously the value was evaluated to be TRUE. Now it's only checked for existence. Given $_POST['_savedok'] is `0` or `false`, the check will now pass. Let's therefore use: ($_POST['_savedok'] ?? false) || ($_POST['_saveandclosedok'] ?? false) Same for L:307 -
Jochen Roth uploaded patch set 3 06/29/21, 11:47
-
core-ci voted on patch set 3 V -1 06/29/21, 11:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12798
-
Christian Kuhn rebased onto patch set 4 06/29/21, 20:05
-
Christian Kuhn commented on patch set 4 06/29/21, 20:06
TableController.php:284ReplyDoneTableController.php:287ReplyDone -
core-ci voted on patch set 4 V +1 06/29/21, 20:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12814
-
Christian Kuhn voted on patch set 4 V +1 CR +1 06/29/21, 22:07
-
Oli Bartsch voted on patch set 4 V +1 CR +1 06/29/21, 22:23
-
Christian Kuhn voted on patch set 4 V +2 CR +2 06/30/21, 09:08
-
Christian Kuhn merged patch set 5 06/30/21, 09:08