Review main Merged

69575[BUGFIX] Undefined key warning in table wizard for PHP8

Jochen Roth CR +2 V +2 Normal +223 −6 updated 06/30/21, 09:08

Commit message

Open the table wizard with empty test in the text area
or a click on the save button on table wizard page
thow undefined key warning.
This will avoid php warnings by adding a fallback
value or a check if the key is present.

Added acceptance tests for the table wizard to  make
sure the wizard will work as expected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Jochen Roth uploaded patch set 1 06/25/21, 15:50

  2. core-ci voted on patch set 1 V -1 06/25/21, 16:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12748

  3. Jochen Roth commented on patch set 1 06/25/21, 16:38

    > Patch Set 1: Verified-1 > > Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12748 First we need to merge: https://github.com/TYPO3/styleguide/pull/217 and update the styleguide extension.
  4. Jochen Roth uploaded patch set 2 06/28/21, 20:35

  5. core-ci voted on patch set 2 V -1 06/28/21, 20:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12784

  6. Oli Bartsch commented on patch set 2 06/29/21, 09:32

    TableController.php:284

    What do you think about (int)($row[$this->colsFieldName] ?? 0) instead? IMO easier to read.

    TableController.php:287

    This is change in behaviour. Previously the value was evaluated to be TRUE. Now it's only checked for existence. Given $_POST['_savedok'] is `0` or `false`, the check will now pass. Let's therefore use: ($_POST['_savedok'] ?? false) || ($_POST['_saveandclosedok'] ?? false) Same for L:307
  7. Jochen Roth uploaded patch set 3 06/29/21, 11:47

  8. core-ci voted on patch set 3 V -1 06/29/21, 11:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12798

  9. Christian Kuhn rebased onto patch set 4 06/29/21, 20:05

  10. Christian Kuhn commented on patch set 4 06/29/21, 20:06

    TableController.php:284 Reply

    Done

    TableController.php:287 Reply

    Done
  11. core-ci voted on patch set 4 V +1 06/29/21, 20:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12814

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 06/29/21, 22:07

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 06/29/21, 22:23

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 06/30/21, 09:08

  15. Christian Kuhn merged patch set 5 06/30/21, 09:08