Review main Merged

69632[TASK] Require doctrine/dbal 2.13

Benni Mack CR +2 V +2 Normal +64 −28 updated 06/28/21, 09:26

Commit message

In order to make TYPO3 Core compatible with doctrine/dbal 3.0,
Core now requires doctrine/dbal 2.13 to allow to track all deprecations
and use the forward-facing APIs.

Used composer commands:
* composer req doctrine/dbal:^2.13
* composer req doctrine/dbal:^2.13 -d typo3/sysext/core --no-update
* composer req doctrine/dbal:^2.13 -d typo3/sysext/install --no-update
* composer req doctrine/dbal:^2.13 -d typo3/sysext/redirects --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 57

  1. Benni Mack uploaded patch set 1 06/28/21, 07:20

  2. core-ci voted on patch set 1 V -1 06/28/21, 07:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12767

  3. Christian Kuhn uploaded patch set 2 06/28/21, 08:23

  4. core-ci voted on patch set 2 V +1 06/28/21, 08:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12769

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/28/21, 08:37

  6. Benni Mack voted on patch set 2 V +2 CR +2 06/28/21, 09:26

  7. Benni Mack merged patch set 3 06/28/21, 09:26