Review main Merged

69633[BUGFIX] Undefined array key in install tool

Jochen Roth CR +2 V +2 Normal +175 −12 updated 06/29/21, 10:41

Commit message

A click on "Image Processing", "Configure Installation-Wide Options"
or "Configuration Presets" in the install tool returns
an error in PHP8.

Add fallback for unefined array keys to workaround
the array undefined key warnings.

Add acceptance tests for InstallTool -> Settings module
to make sure settings of each card can be loaded and saved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1318

  1. Jochen Roth uploaded patch set 1 06/28/21, 11:05

  2. core-ci voted on patch set 1 V +1 06/28/21, 11:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12772

  3. Jochen Roth uploaded patch set 2 06/28/21, 15:58

  4. core-ci voted on patch set 2 V +1 06/28/21, 16:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12777

  5. Jochen Roth uploaded patch set 3 06/28/21, 16:25

  6. core-ci voted on patch set 3 V +1 06/28/21, 16:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12778

  7. Jochen Roth updated the commit message in patch set 4 06/28/21, 16:39

  8. core-ci voted on patch set 4 V +1 06/28/21, 16:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12779

  9. Benni Mack voted on patch set 4 V +1 CR +1 06/29/21, 09:31

  10. Oli Bartsch commented on patch set 4 06/29/21, 09:45

    GraphicalFunctions.php:1459

    Duplicate parentheses.

    ConstantConfigurationParser.php:126

    In case previous behaviour is important and should be kept, this has to be `($configurationOption['subcat_name'] ?? false) ?: '__default';` instead.

    LocalConfigurationValueService.php:94

    Is there a reason for using an integer here instead of an empty string? IMO this makes it unnecessary hard to grasp the intention.
  11. Jochen Roth uploaded patch set 5 06/29/21, 10:28

  12. Jochen Roth commented on patch set 5 06/29/21, 10:29

    GraphicalFunctions.php:1459 Reply

    Done

    ConstantConfigurationParser.php:126 Reply

    Done

    LocalConfigurationValueService.php:94 Reply

    Done
  13. Christian Kuhn voted on patch set 5 V +1 CR +1 06/29/21, 10:30

  14. Benni Mack voted on patch set 5 V +1 CR +1 06/29/21, 10:33

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 06/29/21, 10:37

  16. core-ci voted on patch set 5 V +1 06/29/21, 10:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12794

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 06/29/21, 10:40

  18. Christian Kuhn merged patch set 6 06/29/21, 10:41