69633[BUGFIX] Undefined array key in install tool
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts+7 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php2+3 −3
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php2+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/InstallTool/SettingsCest.phpnew+157 −0
- typo3/sysext/install/Classes/Configuration/Mail/SendmailPreset.php+1 −1
- typo3/sysext/install/Classes/Controller/SettingsController.php+1 −1
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php2+3 −3
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+1 −1
Review log 1318
-
Jochen Roth uploaded patch set 1 06/28/21, 11:05
-
core-ci voted on patch set 1 V +1 06/28/21, 11:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12772
-
Jochen Roth uploaded patch set 2 06/28/21, 15:58
-
core-ci voted on patch set 2 V +1 06/28/21, 16:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12777
-
Jochen Roth uploaded patch set 3 06/28/21, 16:25
-
core-ci voted on patch set 3 V +1 06/28/21, 16:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12778
-
Jochen Roth updated the commit message in patch set 4 06/28/21, 16:39
-
core-ci voted on patch set 4 V +1 06/28/21, 16:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12779
-
Benni Mack voted on patch set 4 V +1 CR +1 06/29/21, 09:31
-
Oli Bartsch commented on patch set 4 06/29/21, 09:45
ConstantConfigurationParser.php:126In case previous behaviour is important and should be kept, this has to be `($configurationOption['subcat_name'] ?? false) ?: '__default';` instead.LocalConfigurationValueService.php:94Is there a reason for using an integer here instead of an empty string? IMO this makes it unnecessary hard to grasp the intention. -
Jochen Roth uploaded patch set 5 06/29/21, 10:28
-
Jochen Roth commented on patch set 5 06/29/21, 10:29
GraphicalFunctions.php:1459ReplyDoneConstantConfigurationParser.php:126ReplyDoneLocalConfigurationValueService.php:94ReplyDone -
Christian Kuhn voted on patch set 5 V +1 CR +1 06/29/21, 10:30
-
Benni Mack voted on patch set 5 V +1 CR +1 06/29/21, 10:33
-
Oli Bartsch voted on patch set 5 V +1 CR +1 06/29/21, 10:37
-
core-ci voted on patch set 5 V +1 06/29/21, 10:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12794
-
Christian Kuhn voted on patch set 5 V +2 CR +2 06/29/21, 10:40
-
Christian Kuhn merged patch set 6 06/29/21, 10:41
GraphicalFunctions.php:1459