69634[BUGFIX] Respect 'ignoreRootLevelRestriction' setting
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Xavier Perseguers +1
- Henrik Elsner +1
-
Verified V +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Henrik Elsner +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2124
-
Albrecht Köhnlein uploaded patch set 1 06/28/21, 11:20
-
core-ci voted on patch set 1 V +1 06/28/21, 11:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12773
-
Henrik Elsner commented on patch set 1 V +1 CR +1 07/05/21, 07:32
I tested this in my v10 instance and it worked perfectly fine. Thx for the patch -
Geert Boetzkes voted on patch set 1 CR +1 07/07/21, 09:06
-
Benni Mack commented on patch set 1 CR -1 07/09/21, 10:23
RecordHistory.php:273shouldn't this be handled via the ignoreRootLevelRestrictions information in TCA? This way, it could also work for sys_file_metadata and probably solve some other issues there. looks like this information is not evaluated here. hasPageAccess should check for this information IMHO. -
Albrecht Köhnlein uploaded patch set 2 07/09/21, 17:43
-
Albrecht Köhnlein commented on patch set 2 07/09/21, 17:45
RecordHistory.php:273Reply UnresolvedOf course, you're right. I didn't know about 'ignoreRootLevelRestriction' setting and changed the merge request now. -
core-ci voted on patch set 2 V +1 07/09/21, 17:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13162
-
Benni Mack voted on patch set 2 CR +1 07/09/21, 20:43
-
Geert Boetzkes voted on patch set 2 CR +1 07/12/21, 08:15
-
Henrik Elsner commented on patch set 2 V +1 CR +1 07/12/21, 08:39
Once again i can confirm this works in my v10 -
Tobias Wojtylak voted on patch set 2 CR +1 07/13/21, 12:34
-
Georg Ringer commented on patch set 2 CR -1 07/15/21, 12:21
RecordHistory.php:431should be changed to $GLOBALS['TCA'][$table]['ctrl']['security']['ignoreRootLevelRestriction'] ?? false to avoid notices and errors on php8 -
Henrik Elsner commented on patch set 2 07/15/21, 12:26
RecordHistory.php:431Reply Unresolvedill do that -
Henrik Elsner uploaded patch set 3 07/15/21, 12:27
-
Georg Ringer voted on patch set 3 CR +1 07/15/21, 12:34
-
core-ci voted on patch set 3 V +1 07/15/21, 12:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13357
-
Henrik Elsner voted on patch set 3 V +1 CR +1 07/15/21, 12:50
-
Henrik Elsner commented on patch set 3 07/19/21, 07:20
TESTING: - Use an editor account (no admin!) - Change a page slug and revert the redirects - see that the revert did not work (thats the issue here) apply patch -> works -
Xavier Perseguers voted on patch set 3 CR +1 07/19/21, 07:52
-
Josef Glatz commented on patch set 3 V +1 CR +1 07/20/21, 13:15
Handy patch. From my point of view and with my understanding is this a good place to solve the problem. -
Henrik Elsner commented on patch set 3 08/10/21, 09:52
I'm still hoping for this one to be merged soon. I guess most people are not even aware of the issue, as they cannot see the reversing not happening -
Georg Ringer voted on patch set 3 V +2 CR +2 08/10/21, 12:56
-
Georg Ringer merged patch set 4 08/10/21, 12:56