69635[BUGFIX] Extract switch user handling from EXT:beuser
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 14
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SwitchUser.ts2new+85 −0
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+8 −13
- typo3/sysext/backend/Classes/Controller/SwitchUserController.php2new+178 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+12 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+21 −22
- typo3/sysext/backend/Resources/Public/JavaScript/SwitchUser.jsnew+13 −0
- typo3/sysext/backend/Tests/Unit/Controller/SwitchUserControllerTest.phprenamed+13 −11
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+2 −89
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserSessionRepository.php+0 −36
- typo3/sysext/beuser/Classes/Hook/SwitchBackUserHook.phpdeleted+0 −66
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+22 −13
- typo3/sysext/beuser/ext_localconf.phpdeleted+0 −5
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 1115
-
Oli Bartsch uploaded patch set 1 06/28/21, 15:08
-
core-ci voted on patch set 1 V -1 06/28/21, 15:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12775
-
Oli Bartsch uploaded patch set 2 06/28/21, 17:43
-
core-ci voted on patch set 2 V +1 06/28/21, 17:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12780
-
Oli Bartsch uploaded patch set 3 06/29/21, 08:59
-
core-ci voted on patch set 3 V +1 06/29/21, 09:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12790
-
Benni Mack commented on patch set 3 06/29/21, 09:30
-
Oli Bartsch commented on patch set 3 06/29/21, 11:36
SwitchUser.ts:33ReplyAs discussed, this module takes care of performing the necessary POST requests and is not tightly bound to a <button>. -
Christian Kuhn commented on patch set 3 06/29/21, 12:56
SwitchUserController.php:39let's remove that dependency in the unit test and hardcode to 3 in unit, then make this protected or private. -
Oli Bartsch uploaded patch set 4 06/29/21, 13:09
-
Oli Bartsch commented on patch set 4 06/29/21, 13:10
SwitchUserController.php:39ReplyDone -
core-ci voted on patch set 4 V +1 06/29/21, 13:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12800
-
Christian Kuhn voted on patch set 4 V +1 CR +1 06/29/21, 13:35
-
Benni Mack voted on patch set 4 V +2 CR +2 06/29/21, 14:15
-
Benni Mack merged patch set 5 06/29/21, 14:15
SwitchUser.ts:33