69652[BUGFIX] Add configuration to set SMTP mail domain
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Guido Schmechel +1
- Lina Wolf +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Mail/TransportFactory.php+4 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml4+3 −0
- typo3/sysext/core/Documentation/Changelog/11.5.x/Important-93635-AddMailConfigurationForSettingSmtpDomain.rst5new+47 −0
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+24 −0
Review log 4964
Show 3039 earlier messages
-
Axel Seemann uploaded patch set 1 06/29/21, 08:59
-
core-ci voted on patch set 1 V +1 06/29/21, 09:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12791
-
Oli Bartsch commented on patch set 1 06/29/21, 09:18
Hi, thanks for your Patch. Could you please have a look at https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html regarding documentation of your feature. You can also use https://forger.typo3.com/utilities/rst for bootstrapping the RST file.emailsseems to be duplicatedDefaultConfigurationDescription.yaml:575Is this only necessary for "gmail"? -
Sebastian Mendel commented on patch set 1 06/29/21, 09:49
SMTP, not stmp -
Axel Seemann uploaded patch set 2 06/29/21, 10:37
-
Axel Seemann commented on patch set 2 06/29/21, 10:43
Hi Oliver, I've fixed the commit message, added the Doc and answered your question. Please check.Reply
DoneReply
DoneDefaultConfigurationDescription.yaml:575ReplyNo, it depends on the setup of the relay-server.This can also be necessary for relay-server in company-networks e.g.. But IMOH the gmail relay-server will be the common use case. -
core-ci voted on patch set 2 V +1 06/29/21, 10:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12795
-
Oli Bartsch commented on patch set 2 06/29/21, 10:51
Reply
Still "emial" instead of "emails" :)DefaultConfigurationDescription.yaml:575ReplyOke, so then please let this read at least "if you use e.g. a gmail-relay-server." Otherwise one could think this setting is only relevant for gmail. -
Axel Seemann uploaded patch set 3 06/30/21, 05:01
-
Axel Seemann commented on patch set 3 06/30/21, 05:05
Hi Oliver, I hope I got now the emails thing in the commit message :) and you are now fine with. Regards.Reply
I hope I got it now :)Reply
DoneDefaultConfigurationDescription.yaml:575ReplyRemoved the gmail part. -
core-ci voted on patch set 3 V +1 06/30/21, 05:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12834
-
Guido Schmechel commented on patch set 3 06/30/21, 10:12
Small hint: Features are only allowed for master. So you have to change the commit message "Releases" and should move the RST file in the correct folder. -
Guido Schmechel commented on patch set 3 06/30/21, 10:13
And nitpick: SMTP should be uppercase in the commit headline :-) -
Thomas Maroschik commented on patch set 3 07/05/21, 22:01
This feature is actually a bugfix, as the unconfigured local domain in symfony mailer causes trouble with our google workspace customers. Switching to 11 now is not an option yet. Although creating a transport via DSN is supported in the TransportFactory, you cannot get there as the options are validated beforehand. So we're now forced to implement this functionality as a hook for all instances that are using gsuite relays. Thats a pity as we have to remove it when migrating to 11 soon. -
Josef Glatz commented on patch set 3 07/06/21, 10:14
Feature-93635-AddMailConfigurationForSettingSmtpDomain.rst:22I would love to see an example (like for gmail and/or g-suite)! -
Oliver Hader commented on patch set 3 CR -1 07/06/21, 13:19
Alright, in general I'd be find with this change, however... * either declare it as `FEATURE` and it only will be in TYPO3 v11 (no back-ports) * or declare it as `BUGFIX`, and it can be back-ported to v10 as well; the RST file should be an "Important.RST" instead and having a simple example there really would be great Thx! +1 -
Axel Seemann uploaded patch set 4 07/09/21, 16:01
-
core-ci voted on patch set 4 V -1 07/09/21, 16:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13159
-
Axel Seemann commented on patch set 4 07/09/21, 16:15
Hi Oliver, thank you and the others for the input. Now I've changed the type from FEATURE to BUGFIX and renamed the .rst to a important.rst following your suggestion. I provided this patch with the intention to add this in TYPO3 10.4.x also as for future versions. As this is my first contribution to TYPO3 core, I apologise for my lack of knowledge regarding the type of contribution. I hope now this will be fine :) -
Axel Seemann uploaded patch set 5 07/09/21, 16:22
-
core-ci voted on patch set 5 V +1 07/09/21, 16:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13160
-
Guido Schmechel commented on patch set 5 07/17/21, 10:35
Hi Axel, you definitely don't need to apologise. We are happy about every contribution and here is a thank you for your first contribution :-) I am not extremely deep in the subject, but through another patch I noticed that "local_domain" was added late. Namely in Symfony 5.2: https://github.com/symfony/mailer/blob/5.2/Transport/Smtp/EsmtpTransportFactory.php Due to the composer dependencies in version 10, where symfony/mailer 4.4 can also theoretically still run, there would be an error. My suggestion would be that the whole thing should be seen here as a feature and can only be included in the TYPO3 master. We also have symfony/mailer 5.3 as a basis. -
Oliver Hader commented on patch set 5 CR +1 07/27/21, 16:39
@Axel: Thanks for updating the change & really no need to apologize -
Oliver Hader commented on patch set 5 07/27/21, 16:48
Reply
> Due to the composer dependencies in version 10, where symfony/mailer 4.4 can also theoretically still run, there would be an error. My suggestion would be that the whole thing should be seen here as a feature and can only be included in the TYPO3 master. We also have symfony/mailer 5.3 as a basis. Hm... seems to be a good catch - I'm not sure when 4.4 would/should be used. TYPO3 tarballs (non-composer, old-school) are bundled using symfony/mailer:v5.2.6. Thus, ^4.4 would have to be requested explicitly in those projects. It still needs to be tested, how it behaves in that particular scenario. -
Benni Mack updated the commit message in patch set 6 11/11/21, 14:18
-
Benni Mack commented on patch set 6 11/11/21, 14:18
Propsing to merge this master only (v11) if the merge happens soon. -
Benni Mack updated the commit message in patch set 7 11/11/21, 14:19
-
Guido Schmechel commented on patch set 7 11/11/21, 14:22
If we only merge this into v11 we definitely avoid the problem with the Symfony dependencies ;-) -
core-ci voted on patch set 6 V +1 11/11/21, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19182
-
Simon Gilli commented on patch set 7 CR -1 11/11/21, 14:33
Test is missing, on it... -
core-ci voted on patch set 7 V +1 11/11/21, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19183
-
Simon Gilli uploaded patch set 8 11/11/21, 15:11
-
Simon Gilli uploaded patch set 9 11/11/21, 15:15
-
Simon Gilli uploaded patch set 10 11/11/21, 15:16
-
Simon Gilli uploaded patch set 11 11/11/21, 15:24
-
Simon Gilli uploaded patch set 12 11/11/21, 15:26
-
Simon Gilli voted on patch set 12 V +1 CR +1 11/11/21, 15:27
-
core-ci voted on patch set 8 V +1 11/11/21, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19187
-
core-ci voted on patch set 9 V +1 11/11/21, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19188
-
core-ci voted on patch set 10 V +1 11/11/21, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19189
-
core-ci voted on patch set 11 V +1 11/11/21, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19190
-
core-ci voted on patch set 12 V +1 11/11/21, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19191
-
Simon Gilli commented on patch set 12 11/11/21, 15:42
Feature-93635-AddMailConfigurationForSettingSmtpDomain.rst:22ReplyDone -
Georg Ringer commented on patch set 12 CR +1 11/12/21, 07:35
IMO this is no bugfix but a feature and it is fine to merge that as feature with a feature rst instead of important but I won't block it as bugfix ;) -
Oliver Hader commented on patch set 12 11/12/21, 07:51
Important-93635-AddMailConfigurationForSettingSmtpDomain.rst:29Please make this a little bit more generic * use `example.org` for domain names * try to avoid company names as this RST is rendered and presented on docs.typo3.org Thanks! -
Simon Gilli uploaded patch set 13 11/12/21, 11:05
-
Simon Gilli commented on patch set 13 V +1 CR +1 11/12/21, 11:05
Important-93635-AddMailConfigurationForSettingSmtpDomain.rst:29ReplyDone -
core-ci voted on patch set 13 V +1 11/12/21, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19203
-
Stefan Bürk voted on patch set 13 V +1 CR +1 11/12/21, 17:24
-
Oliver Hader voted on patch set 13 CR +1 11/12/21, 17:33
-
Jonas Eberle commented on patch set 13 11/12/21, 17:36
Important-93635-AddMailConfigurationForSettingSmtpDomain.rst:21EHLO -
Lina Wolf commented on patch set 13 CR -1 11/13/21, 10:10
Working on documentation -
Lina Wolf rebased onto patch set 14 11/13/21, 10:23
-
Lina Wolf commented on patch set 14 CR +1 11/13/21, 10:24
Looks good to me, didn't try it out -
Lina Wolf commented on patch set 14 11/13/21, 10:26
Important-93635-AddMailConfigurationForSettingSmtpDomain.rst:21ReplyDone -
core-ci voted on patch set 14 V +1 11/13/21, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19221
-
Stefan Bürk uploaded patch set 15 11/13/21, 11:01
-
Stefan Bürk commented on patch set 15 V +1 CR +1 11/13/21, 11:03
Important-93635-AddMailConfigurationForSettingSmtpDomain.rst:21ReplyNow done. -
core-ci voted on patch set 15 V +1 11/13/21, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19223
-
Oliver Hader voted on patch set 15 CR +1 11/13/21, 11:31
-
Lina Wolf commented on patch set 15 CR +1 11/13/21, 12:52
looks good -
Guido Schmechel voted on patch set 15 CR +1 11/13/21, 17:23
-
Oliver Hader voted on patch set 15 V +2 CR +2 11/13/21, 17:44
-
Oliver Hader merged patch set 16 11/13/21, 17:44