Review main Merged

69653[BUGFIX] Fatal in ext:form using LanguageServiceFactory

Christian Kuhn CR +2 V +2 Easy +9 −20 updated 06/29/21, 10:40

Commit message

Patch #94414 broke a case in ext:form leading to a
fatal, easily reproducible when opening a content
element having a form.
The class is internal and only used in backend
through a hook and can thus rely on GLOBALS['LANG']
like so many other backend classes do.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/29/21, 09:57

  2. Benni Mack voted on patch set 1 V +1 CR +1 06/29/21, 09:59

  3. core-ci voted on patch set 1 V +1 06/29/21, 10:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12793

  4. Jochen Roth voted on patch set 1 V +1 CR +1 06/29/21, 10:39

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 06/29/21, 10:39

  6. Christian Kuhn merged patch set 2 06/29/21, 10:40