Review main Merged

69656[TASK] Add a channel column to sys_log

crell CR +2 V +2 Normal +167 −3 updated 07/01/21, 18:55

Commit message

The channel column is a text field intended to suppplant the type column.
For now, all types map over to column based on a lookup table.

Also, repurpose the level column to a string to store the PSR-3 level.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • crell +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1828

Show 23 earlier messages
  1. crell uploaded patch set 1 06/29/21, 16:06

  2. core-ci voted on patch set 1 V -1 06/29/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12807

  3. Christian Kuhn rebased onto patch set 2 06/29/21, 16:23

  1. core-ci voted on patch set 2 V +1 06/29/21, 16:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12808

  2. crell uploaded patch set 3 06/29/21, 17:42

  3. core-ci voted on patch set 3 V +1 06/29/21, 17:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12811

  4. crell uploaded patch set 4 06/30/21, 15:09

  5. core-ci voted on patch set 4 V -1 06/30/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12857

  6. crell uploaded patch set 5 06/30/21, 15:20

  7. crell rebased onto patch set 6 06/30/21, 15:21

  8. core-ci voted on patch set 6 V +1 06/30/21, 15:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12859

  9. core-ci voted on patch set 5 V +1 06/30/21, 15:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12858

  10. crell uploaded patch set 7 06/30/21, 16:04

  11. core-ci voted on patch set 7 V -1 06/30/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12860

  12. crell uploaded patch set 8 06/30/21, 19:24

  13. core-ci voted on patch set 8 V +1 06/30/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12872

  14. Benni Mack uploaded patch set 9 06/30/21, 20:34

  15. Benni Mack voted on patch set 9 V +1 CR +1 06/30/21, 20:34

  16. crell commented on patch set 9 CR +1 06/30/21, 20:39

    Benni's changes are fine by me.
  17. core-ci voted on patch set 9 V +1 06/30/21, 20:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12873

  18. Christian Kuhn commented on patch set 9 06/30/21, 23:32

    interesting. the upgrade wizard doesn't kick in for me. will analyze deeper tomorrow.
  19. Benni Mack uploaded patch set 10 07/01/21, 08:39

  20. Benni Mack commented on patch set 10 V +1 CR +1 07/01/21, 08:41

    I also had a re-run on a MariaDB 5.5 platform and found out that the prepare only works with positional parameters, which I changed now.
  21. core-ci voted on patch set 10 V +1 07/01/21, 08:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12888

  22. crell commented on patch set 10 CR +1 07/01/21, 15:40

    Reply

    Damnit, Postgres/Doctrine!
  23. Christian Kuhn voted on patch set 10 V +1 CR +1 07/01/21, 15:54

  24. Benni Mack voted on patch set 10 V +2 CR +2 07/01/21, 18:55

  25. Benni Mack merged patch set 11 07/01/21, 18:55