69656[TASK] Add a channel column to sys_log
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- crell +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+4 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+9 −1
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+1 −0
- typo3/sysext/core/Classes/Error/ErrorHandler.php+1 −0
- typo3/sysext/core/Classes/SysLog/Type.php+51 −1
- typo3/sysext/core/ext_tables.sql+2 −1
- typo3/sysext/install/Classes/Updates/SysLogChannel.phpnew+97 −0
- typo3/sysext/install/ext_localconf.php+2 −0
Review log 1828
Show 23 earlier messages
-
crell uploaded patch set 1 06/29/21, 16:06
-
core-ci voted on patch set 1 V -1 06/29/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12807
-
Christian Kuhn rebased onto patch set 2 06/29/21, 16:23
-
core-ci voted on patch set 2 V +1 06/29/21, 16:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12808
-
crell uploaded patch set 3 06/29/21, 17:42
-
core-ci voted on patch set 3 V +1 06/29/21, 17:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12811
-
crell uploaded patch set 4 06/30/21, 15:09
-
core-ci voted on patch set 4 V -1 06/30/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12857
-
crell uploaded patch set 5 06/30/21, 15:20
-
crell rebased onto patch set 6 06/30/21, 15:21
-
core-ci voted on patch set 6 V +1 06/30/21, 15:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12859
-
core-ci voted on patch set 5 V +1 06/30/21, 15:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12858
-
crell uploaded patch set 7 06/30/21, 16:04
-
core-ci voted on patch set 7 V -1 06/30/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12860
-
crell uploaded patch set 8 06/30/21, 19:24
-
core-ci voted on patch set 8 V +1 06/30/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12872
-
Benni Mack uploaded patch set 9 06/30/21, 20:34
-
Benni Mack voted on patch set 9 V +1 CR +1 06/30/21, 20:34
-
crell commented on patch set 9 CR +1 06/30/21, 20:39
Benni's changes are fine by me. -
core-ci voted on patch set 9 V +1 06/30/21, 20:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12873
-
Christian Kuhn commented on patch set 9 06/30/21, 23:32
interesting. the upgrade wizard doesn't kick in for me. will analyze deeper tomorrow. -
Benni Mack uploaded patch set 10 07/01/21, 08:39
-
Benni Mack commented on patch set 10 V +1 CR +1 07/01/21, 08:41
I also had a re-run on a MariaDB 5.5 platform and found out that the prepare only works with positional parameters, which I changed now. -
core-ci voted on patch set 10 V +1 07/01/21, 08:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12888
-
crell commented on patch set 10 CR +1 07/01/21, 15:40
Reply
Damnit, Postgres/Doctrine! -
Christian Kuhn voted on patch set 10 V +1 CR +1 07/01/21, 15:54
-
Benni Mack voted on patch set 10 V +2 CR +2 07/01/21, 18:55
-
Benni Mack merged patch set 11 07/01/21, 18:55