Review main Merged

69658[BUGFIX] Replace usage of deprecated method in ClassSchema

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 06/30/21, 09:16

Commit message

The method getCollectionValueType() is deprecated
since symfony 5.3 and has therefore been replaced
by getCollectionValueTypes().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 06/29/21, 20:18

  2. Oli Bartsch updated the commit message in patch set 2 06/29/21, 20:19

  3. core-ci voted on patch set 1 V +1 06/29/21, 20:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12816

  4. core-ci voted on patch set 2 V +1 06/29/21, 20:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12817

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/29/21, 21:30

  6. Jochen Roth voted on patch set 2 V +1 CR +1 06/30/21, 09:16

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/30/21, 09:16

  8. Christian Kuhn merged patch set 3 06/30/21, 09:16