Review main Merged

69659[BUGFIX] Return PSR-7 responses in PermissionController

Oli Bartsch CR +2 V +2 Easy +7 −2 updated 06/30/21, 09:11

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1012

  1. Oli Bartsch uploaded patch set 1 06/29/21, 20:51

  2. core-ci voted on patch set 1 V +1 06/29/21, 21:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12818

  3. Christian Kuhn commented on patch set 1 CR -1 06/29/21, 21:35

    PermissionController.php:339

    imho: keep that call, it's the extbase-way for client redirects. simply add a return: this will still throw in v11 which is ok'ish, but will use the return after v12 cleanup-round.
  4. Oli Bartsch uploaded patch set 2 06/29/21, 21:38

  5. Oli Bartsch commented on patch set 2 06/29/21, 21:40

    PermissionController.php:339 Reply

    Restored the previous behaviour. Don't want to add the return now, since this is currently a void method and does not return anything. As soon as this will return the PSR-7 response, this can be changed together with the actions return type annotation.
  6. Christian Kuhn commented on patch set 2 06/29/21, 21:43

    PermissionController.php:339 Reply

    i described in the according .rst that the return should be added to be upwards compatible.
  7. Christian Kuhn commented on patch set 2 06/29/21, 21:45

    PermissionController.php:339 Reply

    so you can simple add both the method return type plus the return call in the method and don't need to do anything in v12 there anymore ... that's why i described that as 'best practice' in the .rst.
  8. core-ci voted on patch set 2 V +1 06/29/21, 21:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12821

  9. Christian Kuhn commented on patch set 2 V +1 CR +1 06/29/21, 22:04

    PermissionController.php:339 Reply

    not mission critical, we'll keep as is now.
  10. Jochen Roth voted on patch set 2 V +1 CR +1 06/30/21, 09:10

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 06/30/21, 09:11

  12. Christian Kuhn merged patch set 3 06/30/21, 09:11