Review main Merged

69661[BUGFIX] Remove unused LanguageService in SlugService

Christian Kuhn CR +2 V +2 Easy +1 −10 updated 06/30/21, 09:08

Commit message

This currently logs a deprecation entry since
LanguageService shouldn't be injected any longer.
The property is unused and can be dropped.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 812

  1. Christian Kuhn uploaded patch set 1 06/29/21, 21:27

  2. core-ci voted on patch set 1 V -1 06/29/21, 21:37 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12820

  3. Oli Bartsch uploaded patch set 2 06/29/21, 21:46

  4. Christian Kuhn uploaded patch set 3 06/29/21, 21:47

  5. core-ci voted on patch set 2 V -1 06/29/21, 21:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12822

  6. core-ci commented on patch set 3 06/29/21, 21:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12823

  7. Christian Kuhn uploaded patch set 4 06/29/21, 21:50

  8. core-ci voted on patch set 4 V +1 06/29/21, 22:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12824

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 06/29/21, 22:24

  10. Jochen Roth voted on patch set 4 V +1 CR +1 06/30/21, 09:07

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 06/30/21, 09:08

  12. Christian Kuhn merged patch set 5 06/30/21, 09:08