Review main Merged

69663[TASK] Switch belog to use channels, not types

crell CR +2 V +2 Hard +218 −91 updated 02/26/23, 11:58

Commit message

The channel field is more flexible than types, and will be populated
by PSR-3 loggers as well. Switch belog to use that instead of the old
type ints.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2434

Show 59 earlier messages
  1. crell uploaded patch set 1 06/29/21, 23:06

  2. core-ci voted on patch set 1 V -1 06/29/21, 23:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12828

  3. Benni Mack rebased onto patch set 2 07/01/21, 18:58

  4. Benni Mack commented on patch set 2 07/01/21, 19:00

    LogEntryRepository.php:94 Unresolved

    any reason why this is commented out?

    Filter.html:68 Unresolved

    should we keep the labels translatable in this place? or have at least a mapping?
  5. core-ci voted on patch set 2 V -1 07/01/21, 19:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12907

  6. Benni Mack uploaded patch set 3 07/01/21, 20:24

  7. core-ci voted on patch set 3 V -1 07/01/21, 20:37 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12909

  8. Benni Mack uploaded patch set 4 07/05/21, 06:27

  9. core-ci voted on patch set 4 V +1 07/05/21, 06:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12958

  1. Benni Mack uploaded patch set 5 07/05/21, 16:10

  2. Benni Mack voted on patch set 5 V +1 CR +1 07/05/21, 16:11

  3. core-ci voted on patch set 5 V +1 07/05/21, 16:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12975

  4. crell uploaded patch set 6 07/08/21, 15:17

  5. crell commented on patch set 6 07/08/21, 15:19

    This version now also lets the user filter by level-at-least, and fixes the system info widget to point to the "php" channel. I think this is mostly ready to go, with the one caveat above.

    LogEntryRepository.php:230 Unresolved

    I suspect this isn't the preferred way to handle this default. If there is some other preferred way, let me know and I'll switch it.
  6. core-ci voted on patch set 6 V -1 07/08/21, 15:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13109

  7. crell uploaded patch set 7 07/09/21, 11:05

  8. core-ci voted on patch set 7 V +1 07/09/21, 11:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13134

  9. Helmut Hummel commented on patch set 7 07/20/21, 08:27

    In general I like this change. It's the base for finally getting rid of direct logging to the database. A lot more could be done for TYPO3's own logger UI, but this could be done on top of this.

    LogEntries.html:103

    What is the tableName replaced with? I know this is annoyingly specific, but in case database operations are logged, also a tableName is logged as well. This column though is currently, when accessing the log module through the info module in the backend. In any case with this change here the column header from above must also be removed, or, an alternative needs be be worked out for the table name information.
  10. crell commented on patch set 7 07/20/21, 15:44

    LogEntries.html:103 Reply

    Hm. Nothing at the moment. It's been a week so I don't recall why I removed that field outright. It may have been just to make room, I am not sure. (I probably saw no use of that field in my database, so considered it vestigial.) I can probably restore it, I think, though that only increases the need for a follow up to redesign that whole form to make it nicer to work with. (Definitely out of scope here.)
  11. crell uploaded patch set 8 07/26/21, 19:40

  12. core-ci voted on patch set 8 V +1 07/26/21, 19:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13782

  13. crell commented on patch set 8 07/26/21, 20:07

    LogEntries.html:103 Reply

    Ah, it got lost along with the submodule layout business by accident, which I don't understand. I've restored it as before, ish, but I don't know what the submodule bits are about to begin with. We can move forward as is, or someone can fill me in on how that even works and we can likely clean it out entirely. :-) Possibly later on that.
  14. Georg Ringer commented on patch set 8 08/02/21, 17:58

    LogEntryRepository.php:206

    does this work on every platform? or maybe using a group by? same below

    LogEntryRepository.php:208

    is this localizeable?
  15. crell commented on patch set 8 08/02/21, 19:20

    LogEntryRepository.php:206 Reply

    I think SELECT DISTINCT is pretty universal? I've never used a DB that didn't support it, at least. If someone else knows of a more portable approach, let me know and I can switch it.

    LogEntryRepository.php:208 Reply

    As is, probably not. I am not sure what the best way to make that translatable is. I'm happy to switch it to whatever someone tells me is the better way to handle it, because I agree this is not it.
  16. crell uploaded patch set 9 08/04/21, 16:37

  17. core-ci voted on patch set 9 V +1 08/04/21, 16:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14098

  18. crell commented on patch set 9 08/04/21, 17:12

    LogEntryRepository.php:206 Reply

    Done
  19. crell uploaded patch set 10 08/05/21, 15:01

  20. crell commented on patch set 10 08/05/21, 15:06

    LogEntryRepository.php:208 Reply

    Done
  21. core-ci voted on patch set 10 V +1 08/05/21, 15:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14150

  22. Georg Ringer voted on patch set 10 V +1 CR +1 08/10/21, 14:25

  23. Benni Mack voted on patch set 10 V +2 CR +2 08/10/21, 14:42

  24. Benni Mack merged patch set 11 08/10/21, 14:44

  25. Oliver Hader commented on patch set 11 02/26/23, 11:58

    Filter.html:71 Unresolved

    This inline invocation seems to be wrong, shouldn't it be `key:'all'`?