Review main Merged

69665[TASK] Remove all code occurrences from showRemovedLocalizationRecords

Nikita Hovratov CR +2 V +2 Normal +60 −77 updated 11/22/23, 21:46

Commit message

The TCA option showRemovedLocalizationRecords was former used to enable
showing 'dangling' records (localized records without parent). Because
it was subject to a broken db structure, its usage was removed in patch
f6f36d3. But there was still code mentioning this key without using it.

A TCA migration removes this option and logs a message which pinpoints
the lack of usage.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 78

  1. Nikita Hovratov uploaded patch set 1 06/30/21, 08:02

  2. core-ci voted on patch set 1 V +1 06/30/21, 08:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12837

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/30/21, 08:18

  4. Simon Gilli voted on patch set 1 V +1 CR +1 06/30/21, 08:40

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 06/30/21, 08:49

  6. Christian Kuhn merged patch set 2 06/30/21, 08:49

  7. Oli Bartsch commented on patch set 2 06/30/21, 09:13

    TcaMigration.php:425

    No type-safety check

    TcaMigration.php:432

    and it should

    TcaMigrationTest.php:817

    Another test, checking the migration with another type than inline would be great. See the other test, which always test all properties, evaluated in the migration.
  8. Nikita Hovratov commented on patch set 2 11/22/23, 21:46

    TcaMigration.php:425 Reply

    Done

    TcaMigration.php:432 Reply

    Done

    TcaMigrationTest.php:817 Reply

    Done