Review 9.5 Merged

69666[BUGFIX] Declare guzzlehttp/psr7 dependency

Christian Kuhn CR +2 V +2 Easy +7 −5 updated 06/30/21, 17:07

Commit message

guzzlehttp/psr7 is not only an indirect dependency
from guzzlehttp/guzzle, but also a direct core
dependency since we extend LazyOpenStream in
SelfEmittableLazyOpenStream. Declare that dependency
directly, which also blocks upcoming guzzlehttp/psr7:2.0
which is currently incompatible with our core use.

composer req guzzlehttp/psr7:^1.4.0 --no-update
composer req guzzlehttp/psr7:^1.4.0 -d typo3/sysext/core --no-update
composer update --lock

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • David Bruchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Christian Kuhn uploaded patch set 1 06/30/21, 09:01

  2. core-ci voted on patch set 1 V +1 06/30/21, 09:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12844

  3. David Bruchmann commented on patch set 1 CR +1 06/30/21, 10:51

    Unresolved

    can't test it in the moment
  4. Christian Kuhn voted on patch set 1 V +2 CR +2 06/30/21, 17:07

  5. Christian Kuhn merged patch set 2 06/30/21, 17:07