Review main Merged

69672[BUGFIX] Extend settings ac tests to revert changes when done

Jochen Roth CR +2 V +2 Normal +133 −39 updated 07/29/21, 09:49

Commit message

Settings acceptence tests has been extended to revert
all changes done to the installer when the test finished.

On top of that the tests now verify the changed setting
by re-open the modal and compare the values.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Jochen Roth uploaded patch set 1 06/30/21, 12:47

  2. core-ci voted on patch set 1 V +1 06/30/21, 12:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12854

  3. Jochen Roth uploaded patch set 2 06/30/21, 13:54

  4. core-ci voted on patch set 2 V +1 06/30/21, 14:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12856

  5. Oli Bartsch commented on patch set 2 06/30/21, 14:11

    SettingsCest.php:67

    I would suggest to grab and store the previous value in a variable. Otherwise this may unset a value, set by a previous test. This may also apply for the other tests in this class.
  6. Jochen Roth uploaded patch set 3 07/01/21, 12:53

  7. core-ci voted on patch set 3 V +1 07/01/21, 13:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12896

  8. Jochen Roth commented on patch set 3 07/02/21, 13:07

    SettingsCest.php:67 Reply

    Done
  9. Benni Mack voted on patch set 3 V +1 CR +1 07/05/21, 16:27

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 07/29/21, 09:49

  11. Christian Kuhn merged patch set 4 07/29/21, 09:49