69674[TASK] Replace access to global request in extbase controllers
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+1 −1
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php2+6 −18
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php4+4 −1
- typo3/sysext/extbase/Classes/Mvc/RequestInterface.php+2 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php2+1 −16
Review log 1115
-
Oli Bartsch uploaded patch set 1 06/30/21, 16:53
-
Oli Bartsch updated the commit message in patch set 2 06/30/21, 16:54
-
core-ci voted on patch set 1 V +1 06/30/21, 17:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12861
-
core-ci voted on patch set 2 V +1 06/30/21, 17:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12862
-
Christian Kuhn commented on patch set 2 06/30/21, 17:13
ActionController.php:449let's add a hint here that we can drop this line in v12 again. -
Christian Kuhn commented on patch set 2 06/30/21, 17:14
BackendUserController.php:615nice!AdministrationController.php:579yay :) -
Oli Bartsch uploaded patch set 3 06/30/21, 17:54
-
Oli Bartsch commented on patch set 2 06/30/21, 17:57
BackendUserController.php:615ReplyAckActionController.php:134ReplyDoneActionController.php:449ReplyThis inline annotation needs to stay because UriBuilder->setRequest() as well as MvcPropertyMappingConfigurationService->initializePropertyMappingConfigurationFromRequest() use the concrete Request implementation as type hint, instead of RequestInterface.AdministrationController.php:579ReplyAck -
core-ci voted on patch set 3 V +1 06/30/21, 18:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12866
-
Christian Kuhn uploaded patch set 4 06/30/21, 19:18
-
Christian Kuhn voted on patch set 4 V +1 CR +1 06/30/21, 19:20
-
Jochen Roth voted on patch set 4 V +1 CR +1 06/30/21, 19:23
-
core-ci voted on patch set 4 V +1 06/30/21, 19:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12871
-
Oli Bartsch voted on patch set 4 V +2 CR +2 06/30/21, 20:43
-
Oli Bartsch merged patch set 5 06/30/21, 20:43
ActionController.php:134