Review main Merged

69675[BUGFIX] Do not call getPublicUrl() with second argument set

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 07/01/21, 08:21

Commit message

Since #94193 calling ResourceStorage->getPublicUrl()
with the second argument "$relativeToCurrentScript" set,
is deprecated.

This patch therefore removes this argument from a call
in TypoScriptFrontendController.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 06/30/21, 17:43

  2. core-ci voted on patch set 1 V +1 06/30/21, 17:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12865

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/30/21, 20:22

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 06/30/21, 23:35

  5. Benni Mack voted on patch set 1 V +2 CR +2 07/01/21, 08:21

  6. Benni Mack merged patch set 2 07/01/21, 08:21