69677[BUGFIX] Fix validation and response in PasswordRecoveryController
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Rudy Gnodde +1
-
Verified V +2 Done
- Christian Kuhn +2
- Rudy Gnodde +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1926
Show 1 earlier messages
-
Torben Hansen uploaded patch set 1 07/01/21, 05:07
-
core-ci voted on patch set 1 V -1 07/01/21, 05:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12884
-
Torben Hansen uploaded patch set 2 07/01/21, 05:26
-
core-ci voted on patch set 2 V +1 07/01/21, 05:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12885
-
Benni Mack commented on patch set 2 07/01/21, 08:07
-
Torben Hansen uploaded patch set 3 07/01/21, 11:24
-
Torben Hansen commented on patch set 3 07/01/21, 11:25
PasswordRecoveryController.php:136ReplyDone. Updated the comment to suite the current behavior. -
core-ci voted on patch set 3 V +1 07/01/21, 11:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12894
-
Benni Mack voted on patch set 3 CR +1 07/05/21, 09:03
-
Christine Zoglmeier uploaded patch set 4 08/12/21, 10:16
-
core-ci voted on patch set 4 V -1 08/12/21, 10:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14693
-
Stefan Busemann commented on patch set 4 V +1 CR +1 08/12/21, 11:44
Passwort Reset tested with PHP 7.4 in local instance -
Stefan Busemann uploaded patch set 5 08/12/21, 11:57
-
core-ci voted on patch set 5 V +1 08/12/21, 12:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14713
-
Oli Bartsch commented on patch set 5 CR -1 08/12/21, 12:16
PasswordRecoveryController.php:106$this->redirect throws StopActionException which results in a direct execution of the redirect. Therefore, the method will never return a Response => This should be removed again.PasswordRecoveryController.php:241$this->redirect throws StopActionException which results in a direct execution of the redirect. Therefore, the method will never return a Response => This should be removed again. -
Stefan Busemann uploaded patch set 6 08/12/21, 12:33
-
core-ci voted on patch set 6 V +1 08/12/21, 12:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14721
-
Rudy Gnodde voted on patch set 6 CR +1 08/13/21, 12:43
-
Wouter Wolters voted on patch set 6 CR +1 08/13/21, 12:57
-
Christian Kuhn uploaded patch set 7 08/14/21, 09:57
-
Christian Kuhn voted on patch set 7 V +1 CR +1 08/14/21, 10:03
-
core-ci voted on patch set 7 V +1 08/14/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15050
-
Rudy Gnodde voted on patch set 7 V +1 CR +1 08/14/21, 10:20
-
Christian Kuhn voted on patch set 7 V +2 CR +2 08/14/21, 10:27
-
Christian Kuhn commented on patch set 7 08/14/21, 10:29
PasswordRecoveryController.php:106ReplyDonePasswordRecoveryController.php:241ReplyDone -
Christian Kuhn merged patch set 8 08/14/21, 10:29
PasswordRecoveryController.php:136