Review main Merged

69677[BUGFIX] Fix validation and response in PasswordRecoveryController

Torben Hansen CR +2 V +2 Normal +41 −24 updated 08/14/21, 10:29

Commit message

Since the introduction of `ForwardResponse` in Extbase in #92815
password rules and hash validation in the PasswordRecoveryController
did not always lead to the expected forward of the request, since
initialize*Actions in Extbase do not handle a potential response.

This patch moves the existing validation logic to the corresponding
controller actions, so `ForwardResponse` objects can be handled
properly.

Also, all Extbase actions now return PSR-7 responses where suitable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Rudy Gnodde +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1926

Show 1 earlier messages
  1. Torben Hansen uploaded patch set 1 07/01/21, 05:07

  1. core-ci voted on patch set 1 V -1 07/01/21, 05:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12884

  2. Torben Hansen uploaded patch set 2 07/01/21, 05:26

  3. core-ci voted on patch set 2 V +1 07/01/21, 05:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12885

  4. Benni Mack commented on patch set 2 07/01/21, 08:07

    PasswordRecoveryController.php:136

    is this comment correct? "if the hash it isexpired"
  5. Torben Hansen uploaded patch set 3 07/01/21, 11:24

  6. Torben Hansen commented on patch set 3 07/01/21, 11:25

    PasswordRecoveryController.php:136 Reply

    Done. Updated the comment to suite the current behavior.
  7. core-ci voted on patch set 3 V +1 07/01/21, 11:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12894

  8. Benni Mack voted on patch set 3 CR +1 07/05/21, 09:03

  9. Christine Zoglmeier uploaded patch set 4 08/12/21, 10:16

  10. core-ci voted on patch set 4 V -1 08/12/21, 10:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14693

  11. Stefan Busemann commented on patch set 4 V +1 CR +1 08/12/21, 11:44

    Passwort Reset tested with PHP 7.4 in local instance
  12. Stefan Busemann uploaded patch set 5 08/12/21, 11:57

  13. core-ci voted on patch set 5 V +1 08/12/21, 12:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14713

  14. Oli Bartsch commented on patch set 5 CR -1 08/12/21, 12:16

    PasswordRecoveryController.php:106

    $this->redirect throws StopActionException which results in a direct execution of the redirect. Therefore, the method will never return a Response => This should be removed again.

    PasswordRecoveryController.php:241

    $this->redirect throws StopActionException which results in a direct execution of the redirect. Therefore, the method will never return a Response => This should be removed again.
  15. Stefan Busemann uploaded patch set 6 08/12/21, 12:33

  16. core-ci voted on patch set 6 V +1 08/12/21, 12:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14721

  17. Rudy Gnodde voted on patch set 6 CR +1 08/13/21, 12:43

  18. Wouter Wolters voted on patch set 6 CR +1 08/13/21, 12:57

  19. Christian Kuhn uploaded patch set 7 08/14/21, 09:57

  20. Christian Kuhn voted on patch set 7 V +1 CR +1 08/14/21, 10:03

  21. core-ci voted on patch set 7 V +1 08/14/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15050

  22. Rudy Gnodde voted on patch set 7 V +1 CR +1 08/14/21, 10:20

  23. Christian Kuhn voted on patch set 7 V +2 CR +2 08/14/21, 10:27

  24. Christian Kuhn commented on patch set 7 08/14/21, 10:29

    PasswordRecoveryController.php:106 Reply

    Done

    PasswordRecoveryController.php:241 Reply

    Done
  25. Christian Kuhn merged patch set 8 08/14/21, 10:29