Review main Merged

69678[BUGFIX] Explicitly define ContainerInterface service alias

Benjamin Franzke CR +2 V +2 Easy +3 −0 updated 07/01/21, 10:00

Commit message

Account for the symfony deprecation in
https://github.com/symfony/symfony/pull/35879
which deprecated the default alias for Psr\Container\ContainerInterface
and flooded our deprecaton logs since #94269.

This deprecation is intended to help with symfony service locators
(which we do not use), but would break our usecases once we update to
symfony v6 as TYPO3 core and extensions rely on service_container
autowiring for the PSR ContainerInterface alias.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Benjamin Franzke uploaded patch set 1 07/01/21, 09:27

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 07/01/21, 09:29

  3. core-ci voted on patch set 1 V +1 07/01/21, 09:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12890

  4. Benjamin Franzke updated the commit message in patch set 2 07/01/21, 09:37

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 07/01/21, 09:39

  6. Benni Mack voted on patch set 2 V +1 CR +1 07/01/21, 09:42

  7. core-ci voted on patch set 2 V +1 07/01/21, 09:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12891

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 07/01/21, 10:00

  9. Benjamin Franzke merged patch set 3 07/01/21, 10:00