Review main Merged

69680[BUGFIX] Always override new request arguments when forwarding

Alexander Schnitzler CR +2 V +2 Easy +1 −3 updated 07/13/21, 07:37

Commit message

Issue #92815 introduced a regression which triggered an endless
recursion in case of a validation error.

A bit longer explanation:

Given there is an extbase controller action with an argument
whose properties have to validated, extbase maps the incoming
data of the request onto the internally handled arguments
object which then performs the validation on all given arguments.

In case of an error, extbase tries to redirect to the referring
request aka the current request with an updated set of arguments.
The idea is to remove all arguments of the current request to not
trigger the same validation error again on the next try.

There was a condition in the past which eventually led to the
overriding of current arguments which was refactored wrong.

The solution is to simply always use the arguments of the
ForwardResponse.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Alexander Schnitzler uploaded patch set 1 07/01/21, 13:06

  2. Alexander Schnitzler wrote 07/01/21, 13:07

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 07/01/21, 13:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12897

  4. Alexander Schnitzler updated the commit message in patch set 2 07/01/21, 13:21

  5. Alexander Schnitzler updated the commit message in patch set 3 07/01/21, 13:23

  6. core-ci voted on patch set 2 V +1 07/01/21, 13:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12899

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 07/01/21, 13:34

  8. core-ci voted on patch set 3 V +1 07/01/21, 13:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12901

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 07/01/21, 14:25

  10. Benni Mack voted on patch set 3 V +2 CR +2 07/05/21, 09:02

  11. Benni Mack merged patch set 4 07/05/21, 09:02

  12. Benni Mack wrote 07/13/21, 07:37

    Created a revert of this change as I1e671bb1c61ed37c82f5cda513c2699c39280ad7