Review main Merged

69684[BUGFIX] Ensure sys_log.level is varchar

Benni Mack CR +2 V +2 Easy +12 −0 updated 08/10/21, 12:03

Commit message

The update wizard should make sure that the
level field is migrated from integer to varchar
otherwise a BE login is not possible.

The Database Schema Upgrade can handle new fields
properly, but for existing installations the existing
"level" field is an integer and would not allow
new log messages to the database. For this reason,
this workaround is added.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. Benni Mack uploaded patch set 1 07/01/21, 20:21

  2. core-ci voted on patch set 1 V +1 07/01/21, 20:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12908

  3. crell commented on patch set 1 07/01/21, 20:44

    Looks good with one small issue. (And maybe a period on the sentence? I don't know what the TYPO3 convention is, but I like periods on my sentences.)

    SysLogChannel.php:70 Unresolved

    lgoging? :)
  4. Benni Mack commented on patch set 2 07/01/21, 20:46

    Published edit on patch set 1.
  5. crell voted on patch set 2 CR +1 07/01/21, 20:47

  6. core-ci voted on patch set 2 V +1 07/01/21, 21:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12910

  7. Tomas Norre Mikkelsen commented on patch set 2 07/02/21, 06:07

    SysLogChannel.php:71

  8. Benni Mack commented on patch set 2 07/02/21, 08:54

    SysLogChannel.php:71 Reply

    I will update the commit message
  9. Benni Mack updated the commit message in patch set 3 07/02/21, 08:54

  10. Tomas Norre Mikkelsen commented on patch set 3 CR +1 07/02/21, 08:59

    SysLogChannel.php:71 Reply

    Ack
  11. core-ci voted on patch set 3 V +1 07/02/21, 09:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12927

  12. Andreas Kienast voted on patch set 3 CR +1 07/02/21, 09:18

  13. Christian Kuhn commented on patch set 3 07/02/21, 12:25

    SysLogChannel.php:71

    using the schema api would be a cleaner way ... if we keep it like that, we should receive dedicated confirmation 'works with sqlsrv + postgres + sqlite' on this one to be sure.
  14. crell uploaded patch set 4 07/07/21, 18:58

  15. crell commented on patch set 4 07/07/21, 19:00

    It's shocking that Doctrine seems to have no documentation at all on how to use alterTable(), but it seems to be the case. I hope this is right, therefore...

    SysLogChannel.php:71 Reply

    Done
  16. core-ci voted on patch set 4 V +1 07/07/21, 19:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13086

  17. Anja Leichsenring voted on patch set 4 V +1 CR +1 07/08/21, 15:59

  18. Andreas Kienast voted on patch set 4 V +2 CR +2 07/09/21, 08:29

  19. Andreas Kienast merged patch set 5 07/09/21, 08:29

  20. Simon Gilli commented on patch set 5 08/10/21, 12:03

    Sadly this is breaking sqlite because sqlite needs the old and new schema to make changes. I'm on it...