69685[CLEANUP] Inline unnecessary local variables
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 145
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php+2 −4
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+1 −3
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+1 −2
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+1 −2
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+1 −2
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+1 −3
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+2 −4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php+1 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php+1 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/EvaluateDisplayConditions.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldDescriptions.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldLabels.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −2
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+2 −4
- typo3/sysext/backend/Classes/Template/Components/Menu/Menu.php+2 −4
- typo3/sysext/backend/Classes/Template/Components/MenuRegistry.php+1 −2
- typo3/sysext/backend/Classes/Tree/TreeRepresentationNode.php+1 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −10
Show 125 more files
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+2 −5
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −5
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+1 −2
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+1 −2
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php+3 −6
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Database/Driver/PDOStatement.php+2 −4
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+19 −20
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaColumnDefinitionListener.php+1 −3
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaIndexDefinitionListener.php+1 −3
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+1 −3
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+6 −13
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+5 −11
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+1 −2
- typo3/sysext/core/Classes/DependencyInjection/ServiceProviderRegistry.php+1 −2
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/DefaultFunctionsProvider.php+1 −2
- typo3/sysext/core/Classes/FormProtection/AbstractFormProtection.php+1 −2
- typo3/sysext/core/Classes/Html/HtmlParser.php+1 −2
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+4 −8
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+2 −4
- typo3/sysext/core/Classes/Locking/FileLockStrategy.php+1 −3
- typo3/sysext/core/Classes/Log/LogRecord.php+1 −2
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+2 −4
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+1 −3
- typo3/sysext/core/Classes/Page/PageRenderer.php+2 −4
- typo3/sysext/core/Classes/Preparations/TcaPreparation.php+1 −2
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+4 −8
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+3 −9
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php+1 −2
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+1 −3
- typo3/sysext/core/Classes/Resource/Service/MagicImageService.php+1 −2
- typo3/sysext/core/Classes/Resource/AbstractFile.php+1 −3
- typo3/sysext/core/Classes/Resource/FileReference.php+1 −2
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+2 −4
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+3 −8
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −2
- typo3/sysext/core/Classes/Routing/Aspect/AspectFactory.php+1 −2
- typo3/sysext/core/Classes/Routing/Aspect/StaticRangeMapper.php+1 −2
- typo3/sysext/core/Classes/Routing/Enhancer/EnhancerFactory.php+1 −2
- typo3/sysext/core/Classes/Service/IsoCodeService.php+1 −2
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php+1 −3
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −2
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+1 −3
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −2
- typo3/sysext/core/Classes/Utility/CommandUtility.php+1 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −2
- typo3/sysext/core/Classes/Utility/MathUtility.php+2 −4
- typo3/sysext/core/Classes/Utility/PathUtility.php+1 −2
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php+1 −2
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+1 −3
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/CheckValueTest.php+1 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+2 −6
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+2 −4
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −3
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+1 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −2
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+1 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+2 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+1 −2
- typo3/sysext/extbase/Classes/Persistence/Repository.php+2 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/ArrayConverter.php+1 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −2
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+1 −2
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+1 −3
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileDragProvider.php+1 −3
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+1 −3
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+3 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+2 −4
- typo3/sysext/form/Classes/Controller/FormEditorController.php+3 −7
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −2
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+1 −2
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+1 −2
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php+1 −3
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+1 −2
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+1 −3
- typo3/sysext/form/Classes/Service/TranslationService.php+4 −10
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+5 −10
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+2 −4
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+2 −4
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+4 −8
- typo3/sysext/frontend/Classes/Service/TypoLinkCodecService.php+1 −3
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+1 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+1 −3
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+8 −16
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+1 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+12 −14
- typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php+1 −2
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −2
- typo3/sysext/install/Classes/FolderStructure/RootNode.php+1 −2
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −2
- typo3/sysext/install/Classes/Service/EnableFileService.php+1 −2
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+1 −3
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+1 −3
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceVersionRecordMigrationTest.php+1 −2
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+2 −6
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+1 −2
- typo3/sysext/reports/Classes/Report/Status/Status.php+1 −2
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+1 −2
- typo3/sysext/reports/Classes/Report/Status/Typo3Status.php+1 −2
- typo3/sysext/reports/Classes/Status.php+1 −2
- typo3/sysext/reports/Tests/Unit/Report/ServicesListReportTest.php+1 −2
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+1 −3
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+2 −5
- typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php+2 −4
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+3 −6
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+1 −2
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+3 −6
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+3 −7
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php+1 −3
- typo3/sysext/t3editor/Classes/Controller/CodeCompletionController.php+1 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+8 −18
- typo3/sysext/workspaces/Classes/Controller/Remote/MassActionHandler.php+1 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+4 −8
- typo3/sysext/workspaces/Classes/Dependency/DependencyResolver.php+1 −2
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −2
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+2 −6
Review log 67
-
Nikita Hovratov uploaded patch set 1 07/01/21, 20:47
-
Nikita Hovratov commented on patch set 1 07/01/21, 20:51
Any opinions on that? Used phpstorm to detect and autofix those. There is no check to prevent that in the future unfortunately. -
core-ci voted on patch set 1 V -1 07/01/21, 21:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12911
-
Christian Kuhn commented on patch set 1 07/02/21, 12:30
Unsure. There are 2 reasons to keep that: First, it can be useful to give the last assignment a name to make clear what the output is supposed to be. Second, assignment to local variable plus return allow setting a breakpoint just before the return, which can be handy. -
Nikita Hovratov commented on patch set 1 07/02/21, 13:06
Reply
Yeah, didn't think of that. Helps a lot in debugging you are right. Guess I just deactivate the code smell checker in my ide. -
Oli Bartsch commented on patch set 1 07/02/21, 21:02
Reply Unresolved
While I'm all for avoiding unnecessary (one-use) variables, Christian is right, those help on debugging. -
Nikita Hovratov abandoned the change 07/03/21, 16:26
Useful for debugging