Review main Abandoned

69685[CLEANUP] Inline unnecessary local variables

Nikita Hovratov CR 0 V 0 Hard +259 −547 updated 07/03/21, 16:26

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 145

Show 125 more files

Review log 67

  1. Nikita Hovratov uploaded patch set 1 07/01/21, 20:47

  2. Nikita Hovratov commented on patch set 1 07/01/21, 20:51

    Any opinions on that? Used phpstorm to detect and autofix those. There is no check to prevent that in the future unfortunately.
  3. core-ci voted on patch set 1 V -1 07/01/21, 21:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12911

  4. Christian Kuhn commented on patch set 1 07/02/21, 12:30

    Unsure. There are 2 reasons to keep that: First, it can be useful to give the last assignment a name to make clear what the output is supposed to be. Second, assignment to local variable plus return allow setting a breakpoint just before the return, which can be handy.
  5. Nikita Hovratov commented on patch set 1 07/02/21, 13:06

    Reply

    Yeah, didn't think of that. Helps a lot in debugging you are right. Guess I just deactivate the code smell checker in my ide.
  6. Oli Bartsch commented on patch set 1 07/02/21, 21:02

    Reply Unresolved

    While I'm all for avoiding unnecessary (one-use) variables, Christian is right, those help on debugging.
  7. Nikita Hovratov abandoned the change 07/03/21, 16:26

    Useful for debugging