Review main Merged

69691[FEATURE] Improve show columns selection functionality

Oli Bartsch CR +2 V +2 Hard +687 −162 updated 07/05/21, 11:11

Commit message

In #94218, the show columns selection was already improved
by relocating it to each tables' header, making it always
available (not only in single-table view).

Since the used dropdown leads to confusion and visibility
drawbacks for records, having long labels, the selector
now lives in a modal. Besides the columns to select,
the new modal contains some selector options, such as
"select all" or "toggle selection". Those options are
fixed at the top, making them always visible, even for
records with a lot of columns.

Furthermore the checkboxes now use a more suitable
"check" icon, the columns are sorted lexically and
also management fields (e.g. `sorting`) are now
displayed with a human-readable label. This label
is now also used in the table header.

Besides the UX, this patch also brings some technical
improvements. The whole column selection logic is moved
into a dedicated controller, which may allows reuse in
the future (e.g. for the filelist module). Also the
JavaScript part is extracted from the Recordlist JS-module
into a dedicated web component.

Finally some cleanup of the existing code is done, making
it more readable and more efficient.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1118

  1. Oli Bartsch uploaded patch set 1 07/02/21, 15:40

  2. core-ci voted on patch set 1 V +1 07/02/21, 15:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12933

  3. Oli Bartsch uploaded patch set 2 07/02/21, 16:07

  4. Oli Bartsch uploaded patch set 3 07/02/21, 16:09

  5. core-ci voted on patch set 2 V +1 07/02/21, 16:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12934

  6. core-ci voted on patch set 3 V +1 07/02/21, 16:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12935

  7. Oli Bartsch uploaded patch set 4 07/03/21, 00:14

  8. core-ci voted on patch set 4 V +1 07/03/21, 00:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12938

  9. Oli Bartsch uploaded patch set 5 07/03/21, 00:30

  10. core-ci voted on patch set 5 V +1 07/03/21, 00:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12939

  11. Oli Bartsch uploaded patch set 6 07/05/21, 08:11

  12. core-ci voted on patch set 6 V +1 07/05/21, 08:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12960

  13. Benni Mack uploaded patch set 7 07/05/21, 08:56

  14. Benni Mack voted on patch set 7 V +1 CR +1 07/05/21, 08:58

  15. core-ci voted on patch set 7 V +1 07/05/21, 09:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12963

  16. Jochen Roth voted on patch set 7 V +1 CR +1 07/05/21, 10:28

  17. Benni Mack voted on patch set 7 V +2 CR +2 07/05/21, 11:11

  18. Benni Mack merged patch set 8 07/05/21, 11:11