69718[TASK] Unify code in FileList
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #87974File list search bar doesn't work correctly
- Bug #89867'editIconsHook' in Filelist are not considering in search result
- Bug #92247Clipboard actions not available after performing a search in "filelist" module
- Bug #92747When using the search in the file list, you do not get checkboxes for applying clipboard operations etc.
- Bug #93185Modal when deleting file in filelist is not showing correct text
Files 22
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileList.ts+25 −8
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileSearch.tsdeleted+0 −42
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/FileMetaDataCest.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+446 −592
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/CopyCutFileViewHelper.phpdeleted+0 −74
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/EditFileContentViewHelper.phpdeleted+0 −67
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/RenameFileViewHelper.phpdeleted+0 −66
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/ReplaceFileViewHelper.phpdeleted+0 −67
- typo3/sysext/filelist/Classes/FileFacade.phpdeleted+0 −362
- typo3/sysext/filelist/Classes/FileList.php+89 −65
- typo3/sysext/filelist/Configuration/Services.yaml+3 −0
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/filelist/Resources/Private/Layouts/Default.htmldeleted+0 −10
- typo3/sysext/filelist/Resources/Private/Partials/ClipBoard.htmldeleted+0 −5
- typo3/sysext/filelist/Resources/Private/Partials/SearchForm.htmldeleted+0 −13
- typo3/sysext/filelist/Resources/Private/Templates/File/List.htmlnew+58 −0
- typo3/sysext/filelist/Resources/Private/Templates/FileList/Index.htmldeleted+0 −20
- typo3/sysext/filelist/Resources/Private/Templates/FileList/MissingFolder.htmldeleted+0 −9
- typo3/sysext/filelist/Resources/Private/Templates/FileList/Search.htmldeleted+0 −218
- typo3/sysext/filelist/Resources/Public/JavaScript/FileList.js+1 −1
Review log 2335
Show 510 earlier messages
-
Oli Bartsch uploaded patch set 1 07/05/21, 17:15
-
core-ci voted on patch set 1 V -1 07/05/21, 17:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12978
-
Oli Bartsch uploaded patch set 2 07/05/21, 18:35
-
core-ci voted on patch set 2 V -1 07/05/21, 18:46 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12980
-
Oli Bartsch uploaded patch set 3 07/05/21, 19:59
-
core-ci voted on patch set 3 V -1 07/05/21, 20:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12982
-
Oli Bartsch uploaded patch set 4 07/06/21, 11:23
-
core-ci voted on patch set 4 V +1 07/06/21, 11:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13003
-
Oli Bartsch uploaded patch set 5 07/06/21, 23:38
-
core-ci voted on patch set 5 V -1 07/06/21, 23:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13038
-
Benni Mack updated the commit message in patch set 6 07/07/21, 06:38
-
core-ci voted on patch set 6 V -1 07/07/21, 06:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13042
-
Oli Bartsch uploaded patch set 7 07/07/21, 12:11
-
core-ci voted on patch set 7 V -1 07/07/21, 12:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13060
-
Oli Bartsch uploaded patch set 8 07/07/21, 14:46
-
core-ci voted on patch set 8 V +1 07/07/21, 15:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13076
-
Benni Mack voted on patch set 8 V +1 CR +1 07/07/21, 15:39
-
Benni Mack updated the commit message in patch set 9 07/07/21, 16:22
-
Benni Mack voted on patch set 9 V +1 CR +1 07/07/21, 16:23
-
core-ci voted on patch set 9 V +1 07/07/21, 16:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13078
-
Jochen Roth commented on patch set 9 07/07/21, 16:53
When you go to a folder containing let say 100 files and you browse to page 3. After that your enter a search phrase, the view still shows page three but with no results, till you go back to page 1 in the page browser. -
Jochen Roth commented on patch set 9 07/07/21, 17:07
When you open the context menu (click on the file icon) i get this error: > Object with identifier "1:/introduction/Bildschirmfoto_2021-01-19_um_08.31.27_2.png" does not exist in storage -
Benni Mack uploaded patch set 10 07/07/21, 19:11
-
Benni Mack commented on patch set 10 07/07/21, 19:11
Reply
Cannot reproduceReply
Should be fixed now, thanks! -
Benni Mack uploaded patch set 11 07/07/21, 19:22
-
Jochen Roth commented on patch set 11 V +1 CR +1 07/07/21, 19:29
Reply
Seems like a caching issue on my machine which is gone now. I'll keep an eye on it. -
core-ci voted on patch set 11 V +1 07/07/21, 19:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13090
-
Oli Bartsch uploaded patch set 12 07/07/21, 19:57
-
core-ci voted on patch set 12 V +1 07/07/21, 20:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13091
-
core-ci voted on patch set 10 V -1 07/07/21, 20:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13088
-
Benni Mack voted on patch set 12 V +1 CR +1 07/08/21, 06:13
-
Jochen Roth voted on patch set 12 V +1 CR +1 07/08/21, 08:00
-
Oli Bartsch commented on patch set 12 07/08/21, 08:31
Reply
See also: https://forge.typo3.org/issues/94372 -
Oli Bartsch voted on patch set 12 V +2 CR +2 07/08/21, 08:32
-
Oli Bartsch merged patch set 13 07/08/21, 08:32