Review main Merged

69718[TASK] Unify code in FileList

Oli Bartsch CR +2 V +2 Expert +629 −1640 updated 07/08/21, 08:32

Commit message

Currently, the Backend module File > FileList
has two main views:

* The list view
* The search result view

Both are handled via an Extbase controller, even
though no pure Extbase-related feature (validation,
type-converting, persistence) is used.

Instead, the list view is generated by a PHP-based
code "FileList" (similar to DatabaseRecordList),
where as the search result view is built on top of
Fluid. The latter approach hinders flexibility,
and also leads to inconsistencies, due to the nature of
using two different approaches.

Most notable:

- The search result view looks different than the
  list view, also no additional icons are possible.

- The search result view has a clipboard, but does
  not allow to expand.

- The search result view does not respect the listing
  limit, nor is the pagination displayed.

- The search result view changes the module headline
  to "Search: <word>", removing the context on
  which folder the search was performed.

However, the search result view works with the
SearchDemand object which is a clean way to
put the query requirements into the File List
to render the found files.

Therefore, this patch merges both Search Result Fluid
view and PHP-based view back into one, more flexible
and consistent, view. This also means, FileListController
is not longer registered as an Extbase backend module
and some internal ViewHelpers and classes were removed.

The main benefits:
* Exchanging features between DatabaseRecordList and FileList
  are easier to achieve
* Hooks for additional icons also work in the search result view
* Numeric Clipboards also work in the search result view
* Buttons in each found file row look the same now
* The current folder is now also displayed in search result view
* Bookmarking also works properly now and additionally
  also takes a possible searchTerm into account
* The search results are now paginated, respecting the
  listing limit
* Invalid folders do not longer lead to an exception
  in the search result view

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 22

Show 2 more files

Review log 2335

Show 510 earlier messages
  1. Oli Bartsch uploaded patch set 1 07/05/21, 17:15

  2. core-ci voted on patch set 1 V -1 07/05/21, 17:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12978

  3. Oli Bartsch uploaded patch set 2 07/05/21, 18:35

  4. core-ci voted on patch set 2 V -1 07/05/21, 18:46 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12980

  5. Oli Bartsch uploaded patch set 3 07/05/21, 19:59

  6. core-ci voted on patch set 3 V -1 07/05/21, 20:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12982

  7. Oli Bartsch uploaded patch set 4 07/06/21, 11:23

  8. core-ci voted on patch set 4 V +1 07/06/21, 11:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13003

  9. Oli Bartsch uploaded patch set 5 07/06/21, 23:38

  10. core-ci voted on patch set 5 V -1 07/06/21, 23:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13038

  1. Benni Mack updated the commit message in patch set 6 07/07/21, 06:38

  2. core-ci voted on patch set 6 V -1 07/07/21, 06:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13042

  3. Oli Bartsch uploaded patch set 7 07/07/21, 12:11

  4. core-ci voted on patch set 7 V -1 07/07/21, 12:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13060

  5. Oli Bartsch uploaded patch set 8 07/07/21, 14:46

  6. core-ci voted on patch set 8 V +1 07/07/21, 15:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13076

  7. Benni Mack voted on patch set 8 V +1 CR +1 07/07/21, 15:39

  8. Benni Mack updated the commit message in patch set 9 07/07/21, 16:22

  9. Benni Mack voted on patch set 9 V +1 CR +1 07/07/21, 16:23

  10. core-ci voted on patch set 9 V +1 07/07/21, 16:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13078

  11. Jochen Roth commented on patch set 9 07/07/21, 16:53

    When you go to a folder containing let say 100 files and you browse to page 3. After that your enter a search phrase, the view still shows page three but with no results, till you go back to page 1 in the page browser.
  12. Jochen Roth commented on patch set 9 07/07/21, 17:07

    When you open the context menu (click on the file icon) i get this error: > Object with identifier "1:/introduction/Bildschirmfoto_2021-01-19_um_08.31.27_2.png" does not exist in storage
  13. Benni Mack uploaded patch set 10 07/07/21, 19:11

  14. Benni Mack commented on patch set 10 07/07/21, 19:11

    Reply

    Cannot reproduce

    Reply

    Should be fixed now, thanks!
  15. Benni Mack uploaded patch set 11 07/07/21, 19:22

  16. Jochen Roth commented on patch set 11 V +1 CR +1 07/07/21, 19:29

    Reply

    Seems like a caching issue on my machine which is gone now. I'll keep an eye on it.
  17. core-ci voted on patch set 11 V +1 07/07/21, 19:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13090

  18. Oli Bartsch uploaded patch set 12 07/07/21, 19:57

  19. core-ci voted on patch set 12 V +1 07/07/21, 20:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13091

  20. core-ci voted on patch set 10 V -1 07/07/21, 20:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13088

  21. Benni Mack voted on patch set 12 V +1 CR +1 07/08/21, 06:13

  22. Jochen Roth voted on patch set 12 V +1 CR +1 07/08/21, 08:00

  23. Oli Bartsch commented on patch set 12 07/08/21, 08:31

  24. Oli Bartsch voted on patch set 12 V +2 CR +2 07/08/21, 08:32

  25. Oli Bartsch merged patch set 13 07/08/21, 08:32