Review main Merged

69719[BUGFIX] Prevent bootstrap from removing empty csh popover content

Nikita Hovratov CR +2 V +2 Easy +16 −4 updated 08/10/21, 14:40

Commit message

Since bootstrap v5.0.2 the popover module removes empty title and
content html nodes. This plays however against our strategy to load csh
text on demand. To prevent the automatic removal, an empty p-tag is set
in the data-bs-content attribute.

In addition this fixes another two small bugs:
1. Remove the unexpected argument in the setContent method.
2. Add a new update method in Popover to update the arrow position after
fetching csh text.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1114

  1. Nikita Hovratov uploaded patch set 1 07/05/21, 17:15

  2. core-ci voted on patch set 1 V +1 07/05/21, 17:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12979

  3. Nikita Hovratov uploaded patch set 2 07/12/21, 12:17

  4. Nikita Hovratov updated the commit message in patch set 3 07/12/21, 12:20

  5. core-ci voted on patch set 2 V +1 07/12/21, 12:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13228

  6. core-ci voted on patch set 3 V +1 07/12/21, 12:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13229

  7. Riccardo De Contardi commented on patch set 3 V +1 08/08/21, 08:36

    Tested with CSH on CE and pages
  8. Andreas Kienast commented on patch set 3 CR -1 08/08/21, 11:11

    temporary -1, will check if this issue is solved with Bootstrap 5.1
  9. Andreas Kienast commented on patch set 3 CR 0 08/08/21, 12:11

    With Bootstrap 5.1 stuff gets even worse 😕.
  10. Benni Mack commented on patch set 3 08/10/21, 14:34

    Reply

    Yes. let's get this one in first, then move on to the next beast - bootstrap 5.1
  11. Benni Mack voted on patch set 3 V +1 CR +1 08/10/21, 14:35

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 08/10/21, 14:39

  13. Benni Mack voted on patch set 3 V +2 CR +2 08/10/21, 14:39

  14. Benni Mack merged patch set 4 08/10/21, 14:40