69719[BUGFIX] Prevent bootstrap from removing empty csh popover content
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Riccardo De Contardi +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextHelp.ts+2 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Popover.ts+11 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextHelp.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Popover.js+1 −1
Review log 1114
-
Nikita Hovratov uploaded patch set 1 07/05/21, 17:15
-
core-ci voted on patch set 1 V +1 07/05/21, 17:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12979
-
Nikita Hovratov uploaded patch set 2 07/12/21, 12:17
-
Nikita Hovratov updated the commit message in patch set 3 07/12/21, 12:20
-
core-ci voted on patch set 2 V +1 07/12/21, 12:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13228
-
core-ci voted on patch set 3 V +1 07/12/21, 12:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13229
-
Riccardo De Contardi commented on patch set 3 V +1 08/08/21, 08:36
Tested with CSH on CE and pages -
Andreas Kienast commented on patch set 3 CR -1 08/08/21, 11:11
temporary -1, will check if this issue is solved with Bootstrap 5.1 -
Andreas Kienast commented on patch set 3 CR 0 08/08/21, 12:11
With Bootstrap 5.1 stuff gets even worse 😕. -
Benni Mack commented on patch set 3 08/10/21, 14:34
Reply
Yes. let's get this one in first, then move on to the next beast - bootstrap 5.1 -
Benni Mack voted on patch set 3 V +1 CR +1 08/10/21, 14:35
-
Oli Bartsch voted on patch set 3 V +1 CR +1 08/10/21, 14:39
-
Benni Mack voted on patch set 3 V +2 CR +2 08/10/21, 14:39
-
Benni Mack merged patch set 4 08/10/21, 14:40