Review main Merged

69720[BUGFIX] Re-align IRRE header fields for FAL elements

Benni Mack CR +2 V +2 Easy +7 −7 updated 07/12/21, 11:18

Commit message

The IRRE header block of each element (such as "filename" and "title")
renders a "dl" as block as "dl-horizontal" was removed in Bootstrap 4.

This change changes the styling and markup to utilize the
Bootstrap 5 grid structure.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Benni Mack uploaded patch set 1 07/05/21, 19:42

  2. core-ci voted on patch set 1 V +1 07/05/21, 19:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12981

  3. Benni Mack uploaded patch set 2 07/09/21, 09:41

  4. core-ci voted on patch set 2 V +1 07/09/21, 09:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13129

  5. Benni Mack uploaded patch set 3 07/09/21, 13:41

  6. core-ci voted on patch set 3 V +1 07/09/21, 13:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13150

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 07/10/21, 10:26

  8. Nikita Hovratov commented on patch set 3 V -1 07/10/21, 16:58

    The dd tag needs margin-bottom: 0 or it's not centered vertically
  9. Nikita Hovratov commented on patch set 3 V +1 CR +1 07/10/21, 16:59

    Sorry cache.
  10. Benni Mack voted on patch set 3 V +2 CR +2 07/12/21, 11:18

  11. Benni Mack merged patch set 4 07/12/21, 11:18