69722[TASK] Clean up Move Element Controller
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+75 −151
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/ContentMovingPagePositionMap.php+0 −7
- typo3/sysext/backend/Classes/Tree/View/PageMovingPagePositionMap.php+0 −7
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+10 −13
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/MoveElement.html+23 −20
Review log 711
-
Benni Mack uploaded patch set 1 07/05/21, 21:47
-
core-ci voted on patch set 1 V +1 07/05/21, 21:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12988
-
Benni Mack uploaded patch set 2 07/21/21, 07:25
-
core-ci voted on patch set 2 V +1 07/21/21, 07:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13616
-
Benni Mack uploaded patch set 3 07/21/21, 11:28
-
core-ci voted on patch set 3 V +1 07/21/21, 11:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13620
-
Oli Bartsch uploaded patch set 4 07/27/21, 12:23
-
core-ci voted on patch set 4 V +1 07/27/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13811
-
Oli Bartsch voted on patch set 4 V +1 CR +1 07/27/21, 12:34
-
Georg Ringer voted on patch set 4 V +2 CR +2 07/27/21, 14:54
-
Georg Ringer merged patch set 5 07/27/21, 14:54