Review main Merged

69722[TASK] Clean up Move Element Controller

Benni Mack CR +2 V +2 Hard +109 −199 updated 07/27/21, 14:54

Commit message

This change

* Streamlines Controller Code
* Avoids unneeded Fluid assigns
* Uses strict typing

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 711

  1. Benni Mack uploaded patch set 1 07/05/21, 21:47

  2. core-ci voted on patch set 1 V +1 07/05/21, 21:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12988

  3. Benni Mack uploaded patch set 2 07/21/21, 07:25

  4. core-ci voted on patch set 2 V +1 07/21/21, 07:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13616

  5. Benni Mack uploaded patch set 3 07/21/21, 11:28

  6. core-ci voted on patch set 3 V +1 07/21/21, 11:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13620

  7. Oli Bartsch uploaded patch set 4 07/27/21, 12:23

  8. core-ci voted on patch set 4 V +1 07/27/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13811

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 07/27/21, 12:34

  10. Georg Ringer voted on patch set 4 V +2 CR +2 07/27/21, 14:54

  11. Georg Ringer merged patch set 5 07/27/21, 14:54