Review main Merged

69723[DOCS] Complete new pagination changelog rst

Daniel Siepmann CR +2 V +2 Easy +8 −0 updated 07/06/21, 15:13

Commit message

Add missing pagination example to feature rst.
Only paginator is not enough to actually create a new pagination.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Files 1

Review log 913

  1. Daniel Siepmann uploaded patch set 1 07/06/21, 07:10

  2. core-ci voted on patch set 1 V +1 07/06/21, 07:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12997

  3. Daniel Siepmann uploaded patch set 2 07/06/21, 07:26

  4. core-ci voted on patch set 2 V +1 07/06/21, 07:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12998

  5. Oli Bartsch commented on patch set 2 07/06/21, 08:21

    Feature-89603-IntroduceNativePaginationForLists.rst:50

    This should be SimplePagination
  6. Oli Bartsch commented on patch set 3 07/06/21, 14:28

    Published edit on patch set 2.
  7. Oli Bartsch commented on patch set 4 07/06/21, 14:29

    Published edit on patch set 3.
  8. Oli Bartsch voted on patch set 4 V +1 CR +1 07/06/21, 14:29

  9. core-ci voted on patch set 3 V +1 07/06/21, 14:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13017

  10. Oli Bartsch commented on patch set 4 07/06/21, 14:40

    Feature-89603-IntroduceNativePaginationForLists.rst:50 Reply

    Done
  11. core-ci voted on patch set 4 V +1 07/06/21, 14:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13018

  12. Benni Mack voted on patch set 4 V +2 CR +2 07/06/21, 15:13

  13. Benni Mack merged patch set 5 07/06/21, 15:13