Review main Merged

69724[BUGFIX] Set fallback for undefined array key in php8

Jochen Roth CR +2 V +2 Normal +55 −3 updated 07/09/21, 07:40

Commit message

After reset user preferences in settings module the
Configuration Module shows undefined array key warning.
An empty array has been added as fallback to workaround
this issue and improved scrollTo behavior when the user
opens a node in the configuration tree.

Also extended tests to cover such issues in the future.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • crell +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Jochen Roth uploaded patch set 1 07/06/21, 11:35

  2. core-ci voted on patch set 1 V +1 07/06/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13004

  3. Jochen Roth uploaded patch set 2 07/06/21, 15:16

  4. Jochen Roth uploaded patch set 3 07/06/21, 15:19

  5. core-ci voted on patch set 2 V +1 07/06/21, 15:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13022

  6. core-ci voted on patch set 3 V +1 07/06/21, 15:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13023

  7. Benni Mack voted on patch set 3 V +1 CR +1 07/07/21, 16:23

  8. crell voted on patch set 3 CR +1 07/07/21, 17:47

  9. Jochen Roth uploaded patch set 4 07/08/21, 08:44

  10. core-ci voted on patch set 4 V +1 07/08/21, 08:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13097

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 07/08/21, 15:44

  12. crell voted on patch set 4 CR +1 07/08/21, 18:45

  13. Benni Mack voted on patch set 4 V +2 CR +2 07/09/21, 07:40

  14. Benni Mack merged patch set 5 07/09/21, 07:40