Review main Merged

69726[BUGFIX] Do not inject ImageService in ImageViewHelper

Oli Bartsch CR +2 V +2 Easy +13 −21 updated 07/06/21, 14:39

Commit message

The ImageViewHelper is used in install tool context,
when sending the "login successful" or "login failed"
email, while using the SystemEmail layout. Since DI is
not fully available in install tool context, the ImageService
can not be injected in the view helper.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Oli Bartsch uploaded patch set 1 07/06/21, 13:08

  2. Oli Bartsch uploaded patch set 2 07/06/21, 13:12

  3. core-ci voted on patch set 1 V -1 07/06/21, 13:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13008

  4. core-ci voted on patch set 2 V -1 07/06/21, 13:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13009

  5. Oli Bartsch uploaded patch set 3 07/06/21, 13:54

  6. core-ci voted on patch set 3 V +1 07/06/21, 14:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13014

  7. Benni Mack voted on patch set 3 V +1 CR +1 07/06/21, 14:29

  8. Benjamin Franzke voted on patch set 3 V +2 CR +2 07/06/21, 14:35

  9. Benjamin Franzke merged patch set 4 07/06/21, 14:39