Review main Merged

69727[TASK] Define ImageService as lowlevel service

Benjamin Franzke CR +2 V +2 Easy +12 −3 updated 07/07/21, 13:41

Commit message

As identified in #94491, ImageService may be used
in installtool context and is therefore now
defined as lowlevel service via a service provider,
to ensure its dependencies are always available
in install tool contexts.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 69

  1. Benjamin Franzke uploaded patch set 1 07/06/21, 13:25

  2. core-ci voted on patch set 1 V -1 07/06/21, 13:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13010

  3. Benjamin Franzke rebased onto patch set 2 07/06/21, 14:21

  4. core-ci voted on patch set 2 V +1 07/06/21, 14:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13016

  5. Benjamin Franzke uploaded patch set 3 07/06/21, 14:44

  6. core-ci voted on patch set 3 V +1 07/06/21, 15:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13019

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 07/06/21, 15:08

  8. Benni Mack voted on patch set 3 V +2 CR +2 07/07/21, 13:41

  9. Benni Mack merged patch set 4 07/07/21, 13:41