69728[TASK] Deprecate BackendWorkspaceRestriction and FrontendWorkspaceRestriction
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Database/Query/Restriction/BackendWorkspaceRestriction.php+2 −0
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php+10 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php+2 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+3 −6
- typo3/sysext/core/Documentation/Changelog/12.1/Deprecation-98996-DoctrineDBALBackendWorkspaceRestrictionAndFrontendWorkspaceRestriction.rstnew+101 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+9 −9
- typo3/sysext/core/Tests/UnitDeprecated/Database/Query/Restriction/BackendWorkspaceRestrictionTest.phprenamed+2 −1
- typo3/sysext/core/Tests/UnitDeprecated/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.phprenamed+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+10 −0
Review log 1932
Show 47 earlier messages
-
Benni Mack uploaded patch set 1 07/06/21, 15:07
-
core-ci voted on patch set 1 V -1 07/06/21, 15:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13020
-
Benni Mack uploaded patch set 2 07/06/21, 15:24
-
core-ci voted on patch set 2 V -1 07/06/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13025
-
Benni Mack commented on patch set 3 07/07/21, 12:36
Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 07/07/21, 12:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13062
-
Benni Mack wrote 11/29/21, 10:11
Change destination moved from master to main
-
Benni Mack updated the commit message in patch set 4 11/29/21, 13:33
-
core-ci voted on patch set 4 V -1 11/29/21, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20044
-
Benni Mack rebased onto patch set 5 12/01/21, 14:11
-
core-ci voted on patch set 5 V -1 12/01/21, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20322
-
Benni Mack rebased onto patch set 6 02/23/22, 08:12
-
core-ci voted on patch set 6 V -1 02/23/22, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24079
-
Benni Mack rebased onto patch set 7 05/09/22, 07:54
-
core-ci voted on patch set 7 V -1 05/09/22, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27016
-
crell commented on patch set 7 05/17/22, 17:07
PageSlugCandidateProvider.php:139Is there a way to avoid adding more GU:mI calls? We're trying to get rid of them, no? -
Oli Bartsch commented on patch set 7 05/17/22, 17:24
PageSlugCandidateProvider.php:139ReplyWe try to replace GU:mI with DI where applicable. PageRepository however has state and also gets constructor arguments passed. Therefore GU:mI is totally fine here for now. TYPO3 uses this mechanism over simple *new* to provide the XCLASSes Feature (see first sentence of GU:mI PHPDoc). -
Benni Mack uploaded patch set 8 11/03/22, 16:43
-
core-ci voted on patch set 8 V -1 11/03/22, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33060
-
Benni Mack uploaded patch set 9 11/03/22, 17:13
-
core-ci voted on patch set 9 V -1 11/03/22, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33064
-
Benni Mack uploaded patch set 10 11/03/22, 20:00
-
core-ci voted on patch set 10 V +1 11/03/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33079
-
core-ci voted on patch set 10 V -1 11/03/22, 23:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33086
-
core-ci voted on patch set 10 V +1 11/03/22, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33088
-
crell wrote 11/04/22, 00:22
Removed cc crell. -
Benni Mack uploaded patch set 11 11/04/22, 08:33
-
core-ci voted on patch set 11 V +1 11/04/22, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33094
-
Oli Bartsch voted on patch set 11 V +1 CR +1 11/04/22, 10:10
-
Andreas Kienast voted on patch set 11 V +2 CR +2 11/04/22, 10:44
-
Andreas Kienast merged patch set 12 11/04/22, 10:44
-
Oliver Hader voted on patch set 12 CR +1 11/04/22, 11:47