Review main Merged

69728[TASK] Deprecate BackendWorkspaceRestriction and FrontendWorkspaceRestriction

Benni Mack CR +2 V +2 Normal +141 −19 updated 11/04/22, 11:47

Commit message

WorkspaceRestriction solves all cases, the previous
BackendWorkspaceRestriction and FrontendWorkspaceRestriction
do not restrict to either
a) a specific workspace + LIVE records
b) certain version states (esp. NEW/MOVE and DELETED placeholders).

It is highly recommended to use WorkspaceRestriction
which is available since TYPO3 v9.5.x to overcome
these problems step by step throughout TYPO3 Core.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1932

Show 47 earlier messages
  1. Benni Mack uploaded patch set 1 07/06/21, 15:07

  2. core-ci voted on patch set 1 V -1 07/06/21, 15:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13020

  3. Benni Mack uploaded patch set 2 07/06/21, 15:24

  4. core-ci voted on patch set 2 V -1 07/06/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13025

  5. Benni Mack commented on patch set 3 07/07/21, 12:36

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 07/07/21, 12:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13062

  7. Benni Mack wrote 11/29/21, 10:11

    Change destination moved from master to main
  1. Benni Mack updated the commit message in patch set 4 11/29/21, 13:33

  2. core-ci voted on patch set 4 V -1 11/29/21, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20044

  3. Benni Mack rebased onto patch set 5 12/01/21, 14:11

  4. core-ci voted on patch set 5 V -1 12/01/21, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20322

  5. Benni Mack rebased onto patch set 6 02/23/22, 08:12

  6. core-ci voted on patch set 6 V -1 02/23/22, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24079

  7. Benni Mack rebased onto patch set 7 05/09/22, 07:54

  8. core-ci voted on patch set 7 V -1 05/09/22, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27016

  9. crell commented on patch set 7 05/17/22, 17:07

    PageSlugCandidateProvider.php:139

    Is there a way to avoid adding more GU:mI calls? We're trying to get rid of them, no?
  10. Oli Bartsch commented on patch set 7 05/17/22, 17:24

    PageSlugCandidateProvider.php:139 Reply

    We try to replace GU:mI with DI where applicable. PageRepository however has state and also gets constructor arguments passed. Therefore GU:mI is totally fine here for now. TYPO3 uses this mechanism over simple *new* to provide the XCLASSes Feature (see first sentence of GU:mI PHPDoc).
  11. Benni Mack uploaded patch set 8 11/03/22, 16:43

  12. core-ci voted on patch set 8 V -1 11/03/22, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33060

  13. Benni Mack uploaded patch set 9 11/03/22, 17:13

  14. core-ci voted on patch set 9 V -1 11/03/22, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33064

  15. Benni Mack uploaded patch set 10 11/03/22, 20:00

  16. core-ci voted on patch set 10 V +1 11/03/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33079

  17. core-ci voted on patch set 10 V -1 11/03/22, 23:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33086

  18. core-ci voted on patch set 10 V +1 11/03/22, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33088

  19. crell wrote 11/04/22, 00:22

    Removed cc crell.
  20. Benni Mack uploaded patch set 11 11/04/22, 08:33

  21. core-ci voted on patch set 11 V +1 11/04/22, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33094

  22. Oli Bartsch voted on patch set 11 V +1 CR +1 11/04/22, 10:10

  23. Andreas Kienast voted on patch set 11 V +2 CR +2 11/04/22, 10:44

  24. Andreas Kienast merged patch set 12 11/04/22, 10:44

  25. Oliver Hader voted on patch set 12 CR +1 11/04/22, 11:47