Review main Merged

69731[BUGFIX] Do not validate selectTree in SelectTreeElement.ts

Nikita Hovratov CR +2 V +2 Easy +2 −8 updated 07/09/21, 08:17

Commit message

The validation is already done in the FormEngineValidation on load.

In the method loadDataAfter the tree nodes are not yet loaded for
whatever reason and thus the validation always fails if having minitems
set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Nikita Hovratov uploaded patch set 1 07/06/21, 16:23

  2. Nikita Hovratov commented on patch set 1 07/06/21, 16:26

    I found where the error is happening, but I'm unsure why the tree nodes are empty at that point, eventhough the method is called 'loadDataAfter'.
  3. core-ci voted on patch set 1 V +1 07/06/21, 16:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13029

  4. Benni Mack voted on patch set 1 CR +1 07/07/21, 13:42

  5. Andreas Kienast commented on patch set 1 V +1 CR +1 07/09/21, 07:51

    Confirmed, thanks for fixing this. This can be tested with EXT:styleguide in page "elements select". The tree "select_tree_3" had a validation error upon opening the record albeit it was valid.
  6. Benni Mack voted on patch set 1 V +2 CR +2 07/09/21, 08:17

  7. Benni Mack merged patch set 2 07/09/21, 08:17