69731[BUGFIX] Do not validate selectTree in SelectTreeElement.ts
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 67
-
Nikita Hovratov uploaded patch set 1 07/06/21, 16:23
-
Nikita Hovratov commented on patch set 1 07/06/21, 16:26
I found where the error is happening, but I'm unsure why the tree nodes are empty at that point, eventhough the method is called 'loadDataAfter'. -
core-ci voted on patch set 1 V +1 07/06/21, 16:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13029
-
Benni Mack voted on patch set 1 CR +1 07/07/21, 13:42
-
Andreas Kienast commented on patch set 1 V +1 CR +1 07/09/21, 07:51
Confirmed, thanks for fixing this. This can be tested with EXT:styleguide in page "elements select". The tree "select_tree_3" had a validation error upon opening the record albeit it was valid. -
Benni Mack voted on patch set 1 V +2 CR +2 07/09/21, 08:17
-
Benni Mack merged patch set 2 07/09/21, 08:17