Review main Merged

69733[TASK] Avoid access of global request in view helpers

Oli Bartsch CR +2 V +2 Normal +59 −72 updated 07/09/21, 07:56

Commit message

Since #92826, our own RenderingContext implementation,
available in our view helpers, contains the getRequest()
method, which was introduced to reduce the usages of
ControllerContext. In this patch, the majority of the view
helpers was changed to now access the request from
RenderingContext. Unfortunately, by this time, the extbase
Request was still not PSR-7 compatible. Therefore, some
view helpers still had to access $GLOBALS[TYPO3_REQUEST].

Since #94428, the extbase Request finally implements
the PSR-7 ServerRequestInterface, which now allows us
to replace the global access in the remaining view helpers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 3

Files 15

Review log 810

  1. Oli Bartsch uploaded patch set 1 07/06/21, 20:22

  2. core-ci voted on patch set 1 V +1 07/06/21, 20:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13033

  3. Benni Mack voted on patch set 1 CR +1 07/07/21, 07:16

  4. Geert Boetzkes voted on patch set 1 CR +1 07/07/21, 12:04

  5. Oli Bartsch uploaded patch set 2 07/08/21, 10:43

  6. core-ci voted on patch set 2 V +1 07/08/21, 10:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13099

  7. Benni Mack voted on patch set 2 V +1 CR +1 07/09/21, 07:41

  8. Jochen Roth voted on patch set 2 V +1 CR +1 07/09/21, 07:44

  9. Benni Mack voted on patch set 2 V +2 CR +2 07/09/21, 07:56

  10. Benni Mack merged patch set 3 07/09/21, 07:56