69733[TASK] Avoid access of global request in view helpers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 3
Files 15
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/MenuItemViewHelper.php+2 −10
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+1 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/EmailViewHelper.php+1 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+1 −10
- typo3/sysext/fluid/Classes/ViewHelpers/BaseViewHelper.php+1 −10
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+7 −7
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/EmailViewHelperTest.php+17 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/EmailViewHelperTest.php+12 −0
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/BaseViewHelperTest.php+11 −9
Review log 810
-
Oli Bartsch uploaded patch set 1 07/06/21, 20:22
-
core-ci voted on patch set 1 V +1 07/06/21, 20:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13033
-
Benni Mack voted on patch set 1 CR +1 07/07/21, 07:16
-
Geert Boetzkes voted on patch set 1 CR +1 07/07/21, 12:04
-
Oli Bartsch uploaded patch set 2 07/08/21, 10:43
-
core-ci voted on patch set 2 V +1 07/08/21, 10:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13099
-
Benni Mack voted on patch set 2 V +1 CR +1 07/09/21, 07:41
-
Jochen Roth voted on patch set 2 V +1 CR +1 07/09/21, 07:44
-
Benni Mack voted on patch set 2 V +2 CR +2 07/09/21, 07:56
-
Benni Mack merged patch set 3 07/09/21, 07:56