Review main Merged

6974[TASK] Invalid SQL and bad code in tslib_fe

Dmitry Dulepov CR +2 V +2 Easy +20 −6 updated 06/03/13, 20:49

Commit message

tslibe_fe::determineId() contains invalid SQL statement (using "!=")
and bad code (variable "$idQ", missing check for start/stop dates).

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Wouter Wolters +1
  • Verified V +2
    • Steffen Ritter +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 9

  1. Dmitry Dulepov uploaded patch set 2 12/16/11, 14:12

  2. Dmitry Dulepov commented on patch set 2 12/16/11, 14:12

    Fixed typo in the commit message.
  3. Georg Ringer commented on patch set 1 12/16/11, 14:12

    Looks good to me, but someone else must approve
  4. Steffen Ritter commented on patch set 2 V 0 12/16/11, 14:12

    by team member; Looks good to me, approved I'm not sure if this should go to older versions, as it changes behaviour.
  5. Mr. Jenkins commented on patch set 1 12/16/11, 14:12

  6. Mr. Jenkins commented on patch set 2 12/16/11, 14:12

  7. Wouter Wolters commented on patch set 1 12/16/11, 14:12

    Looks good to me, but someone else must approve
    typo invlid must be invalid
  8. Wouter Wolters commented on patch set 2 12/16/11, 14:12

    Verified; Looks good to me, but someone else must approve
  9. Steffen Ritter merged patch set 2 12/16/11, 14:12