Review main Merged

69758[BUGFIX] Properly check shortcut permissions in ShortcutRepository

Oli Bartsch CR +2 V +2 Normal +62 −13 updated 07/12/21, 17:05

Commit message

When fetching available shortcuts for a user, also permissions
are checked by the ShortcutRepository. However previously a lot
of use-cases were missed and the implemented checks were more
or less faulty, especially when it comes to non-admin users.

Therefore, three main topics are now handled properly:

* Evaluation of record edit permissions for shortcuts,
  targeting the record_edit route
* Evaluation of page access permissions for every shortcut
  not targeting the file list
* Proper distinction between shortcuts for file list and
  the ones for other modules, since both use the "id"
  argument, while for the file list, this is a string
  (combined identifier), and for the rest, this is an
  integer (the requested page id or the records' pid)

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1318

  1. Oli Bartsch uploaded patch set 1 07/07/21, 16:23

  2. core-ci voted on patch set 1 V -1 07/07/21, 16:39 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13079

  3. Oli Bartsch uploaded patch set 2 07/07/21, 19:11

  4. core-ci voted on patch set 2 V +1 07/07/21, 19:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13089

  5. Oli Bartsch commented on patch set 2 07/07/21, 22:25

    May also resolves https://forge.typo3.org/issues/93516. Will simultaneously create the backport to check this in v10.
  6. Jochen Roth voted on patch set 2 V +1 CR +1 07/08/21, 08:39

  7. Benni Mack voted on patch set 2 V +1 CR +1 07/08/21, 09:32

  8. Oli Bartsch commented on patch set 2 CR -1 07/08/21, 11:53

    Have to check another other issue report. See the comment above.
  9. Oli Bartsch uploaded patch set 3 07/08/21, 23:02

  10. core-ci voted on patch set 3 V -1 07/08/21, 23:25 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13113

  11. Oli Bartsch uploaded patch set 4 07/09/21, 09:28

  12. core-ci voted on patch set 4 V -1 07/09/21, 09:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13127

  13. Oli Bartsch uploaded patch set 5 07/09/21, 09:51

  14. core-ci voted on patch set 5 V +1 07/09/21, 10:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13130

  15. Jochen Roth voted on patch set 5 V +1 CR +1 07/12/21, 14:50

  16. Benni Mack voted on patch set 5 V +1 CR +1 07/12/21, 14:54

  17. Oli Bartsch voted on patch set 5 V +2 CR +2 07/12/21, 17:05

  18. Oli Bartsch merged patch set 6 07/12/21, 17:05