Review main Merged

69759[BUGFIX] Fix array undefined warnings in "DB Check" Module

Jochen Roth CR +2 V +2 Hard +257 −58 updated 07/08/21, 15:57

Commit message

Add fallback for undefined array keys to make "DB Check"
compatible with PHP8.

Also basic tests have been added to check each page in
the module.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • crell +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Jochen Roth uploaded patch set 1 07/07/21, 16:31

  2. core-ci voted on patch set 1 V +1 07/07/21, 16:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13080

  3. crell commented on patch set 1 CR +1 07/07/21, 17:37

    Looks like good mundane PHP 8 fixin'.
  4. Benni Mack voted on patch set 1 V +1 CR +1 07/08/21, 11:48

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 07/08/21, 15:57

  6. Anja Leichsenring merged patch set 2 07/08/21, 15:57