Review main Merged

69761[BUGFIX] Allow proper back-linking in File List

Benni Mack CR +2 V +2 Normal +78 −71 updated 07/08/21, 16:00

Commit message

The File List now creates links through
the UriBuilder, allowing to use actions (such as rename)
while then keeping search parameter, or pagination parameters
properly.

In addition, some code is now cleaned up and streamlined (e.g.
the styling of the buttons in the "multi-clipboard mode" is now correct).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Benni Mack uploaded patch set 1 07/08/21, 11:03

  2. core-ci voted on patch set 1 V +1 07/08/21, 11:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13102

  3. Oli Bartsch commented on patch set 1 CR -1 07/08/21, 13:38

    On it
  4. Oli Bartsch uploaded patch set 2 07/08/21, 15:06

  5. Oli Bartsch uploaded patch set 3 07/08/21, 15:10

  6. core-ci voted on patch set 2 V +1 07/08/21, 15:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13107

  7. Oli Bartsch uploaded patch set 4 07/08/21, 15:22

  8. Oli Bartsch voted on patch set 4 V +1 CR +1 07/08/21, 15:24

  9. core-ci voted on patch set 3 V +1 07/08/21, 15:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13108

  10. core-ci voted on patch set 4 V +1 07/08/21, 15:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13110

  11. Jochen Roth voted on patch set 4 V +1 CR +1 07/08/21, 15:41

  12. Benni Mack voted on patch set 4 V +2 CR +2 07/08/21, 16:00

  13. Benni Mack merged patch set 5 07/08/21, 16:00