Review main Merged

69763[TASK] Acceptance tests for the Indexed Search

Patryk Miedziaszczyk CR +2 V +2 Normal +66 −1 updated 07/08/21, 17:17

Commit message

Basic test for Indexed Search backend module checking
main modes are loading properly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Tymoteusz Motylewski +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Patryk Miedziaszczyk uploaded patch set 1 07/08/21, 11:51

  2. core-ci voted on patch set 1 V +1 07/08/21, 12:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13105

  3. Oli Bartsch commented on patch set 1 07/08/21, 13:34

    Hi Patryk, thanks for your contribution. Unfortunately you've pushed the same patch multiple times. We use the "git commit --amend" command to make changes to an already pushed patches. For more information abotu this, please have a look at the contribution guide: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/HandlingAPatch/ChangeAPatch.html Therefore, could you please "Abandon" your other patches? You can find the option in the top right corner of each patch (below your name).
  4. Patryk Miedziaszczyk uploaded patch set 2 07/08/21, 15:04

  5. core-ci voted on patch set 2 V +1 07/08/21, 15:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13106

  6. Anja Leichsenring updated the commit message in patch set 3 07/08/21, 15:51

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 07/08/21, 15:51

  8. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 07/08/21, 15:58

  9. core-ci voted on patch set 3 V +1 07/08/21, 16:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13111

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 07/08/21, 17:17

  11. Oli Bartsch merged patch set 4 07/08/21, 17:17