Review 10.4 Merged

69765[BUGFIX] Properly check shortcut permissions in ShortcutRepository

Oli Bartsch CR +2 V +2 Normal +70 −21 updated 07/12/21, 18:22

Commit message

When fetching available shortcuts for a user, also permissions
are checked by the ShortcutRepository. However previously a lot
of use-cases were missed and the implemented checks were more
or less faulty, especially when it comes to non-admin users.

Therefore, three main topics are now handled properly:

* Evaluation of record edit permissions for shortcuts,
  targeting the record_edit route
* Evaluation of page access permissions for every shortcut
  not targeting the file list
* Proper distinction between shortcuts for file list and
  the ones for other modules, since both use the "id"
  argument, while for the file list, this is a string
  (combined identifier), and for the rest, this is an
  integer (the requested page id or the records' pid)

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Peter Kraume +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Peter Kraume +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Oli Bartsch uploaded patch set 1 07/08/21, 23:02

  2. Oli Bartsch uploaded patch set 2 07/08/21, 23:05

  3. Oli Bartsch uploaded patch set 3 07/08/21, 23:06

  4. core-ci voted on patch set 1 V +1 07/08/21, 23:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13114

  5. core-ci voted on patch set 3 V +1 07/08/21, 23:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13116

  6. core-ci voted on patch set 2 V +1 07/08/21, 23:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13115

  7. Peter Kraume voted on patch set 3 V +1 CR +1 07/09/21, 07:59

  8. Jochen Roth voted on patch set 3 V +1 CR +1 07/12/21, 17:34

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 07/12/21, 18:22

  10. Oli Bartsch merged patch set 4 07/12/21, 18:22