Review main Merged

69771[TASK] Make filelist PHP8 compatible

Jochen Roth CR +2 V +2 Hard +250 −65 updated 07/12/21, 17:44

Commit message

Added fallback value for array undefined
keys for filelist as well as for impexp
because it is part of the current clipboard
fuctionality. Introduced new tests for
clipboard and file upload.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 2029

Show 34 earlier messages
  1. Jochen Roth uploaded patch set 1 07/09/21, 11:51

  2. core-ci voted on patch set 1 V +1 07/09/21, 12:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13140

  3. Benni Mack uploaded patch set 2 07/09/21, 12:33

  4. Benni Mack voted on patch set 2 V +1 CR +1 07/09/21, 12:33

  1. core-ci voted on patch set 2 V +1 07/09/21, 12:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13145

  2. Oli Bartsch commented on patch set 2 CR -1 07/09/21, 13:30

    I wonder what the changes in EXT:impexp have to do with the filelist. If this is intended, please let's explain this in the commit message.

    MetaDataAspect.php:104

    Why do we use an empty string instead of null?

    ExtendedFileUtility.php:1147

    Could we use strict comparison here or simply cast it to a bool directly? $keepFileName = (bool)($cmdArr['keepFilename'] ?? false);

    GeneralUtility.php:1411

    Could be casted to a bool.

    FileList.php:782 Unresolved

    Does it even make sense to generate the url with an invalid uid?

    FileList.php:1017 Unresolved

    Does it even make sense to generate the url with an invalid uid?

    ExportController.php:448

    canBeInterpretedAsInteger has a guard clause which check the given value for empty string, object and array. Therefore, I would suggest to use one of these as fallback, to make use of the guard clause. Preferably the empty string.

    ImportExport.php:408

    Could still be possible that $GLOBALS['TCA']['pages']['ctrl']['enablecolumns']['disabled'] is not set $this->dat['records'][$table . ':' . $uid]['data'], which would then still lead to a warning in PHP 8.

    ImportExport.php:695

    Could we please wrap those with parentheses.
  3. Jochen Roth uploaded patch set 3 07/09/21, 22:35

  4. core-ci voted on patch set 3 V -1 07/09/21, 22:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13169

  5. Jochen Roth rebased onto patch set 4 07/12/21, 07:17

  6. core-ci voted on patch set 4 V -1 07/12/21, 07:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13200

  7. Jochen Roth uploaded patch set 5 07/12/21, 07:36

  8. core-ci voted on patch set 5 V +1 07/12/21, 07:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13203

  9. Jochen Roth commented on patch set 5 07/12/21, 07:54

    MetaDataAspect.php:104 Reply

    Ack

    ExtendedFileUtility.php:1147 Reply

    Ack

    GeneralUtility.php:1411 Reply

    Done

    ExportController.php:448 Reply

    Ack

    ImportExport.php:408 Reply

    Ack

    ImportExport.php:695 Reply

    Ack
  10. Benni Mack voted on patch set 5 V +1 CR +1 07/12/21, 08:24

  11. Oli Bartsch commented on patch set 5 CR -1 07/12/21, 11:31

    On it
  12. Oli Bartsch rebased onto patch set 6 07/12/21, 11:32

  13. core-ci voted on patch set 6 V +1 07/12/21, 11:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13224

  14. Oli Bartsch uploaded patch set 7 07/12/21, 12:55

  15. core-ci voted on patch set 7 V +1 07/12/21, 13:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13235

  16. Oli Bartsch voted on patch set 7 V +1 CR +1 07/12/21, 13:08

  17. Benni Mack uploaded patch set 8 07/12/21, 14:58

  18. core-ci voted on patch set 8 V +1 07/12/21, 15:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13247

  19. Benni Mack voted on patch set 8 V +1 CR +1 07/12/21, 15:15

  20. Jochen Roth voted on patch set 8 V +1 CR +1 07/12/21, 15:32

  21. Oli Bartsch uploaded patch set 9 07/12/21, 16:55

  22. Oli Bartsch voted on patch set 9 V +1 CR +1 07/12/21, 16:55

  23. core-ci voted on patch set 9 V +1 07/12/21, 17:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13251

  24. Benni Mack voted on patch set 9 V +2 CR +2 07/12/21, 17:44

  25. Benni Mack merged patch set 10 07/12/21, 17:44