69771[TASK] Make filelist PHP8 compatible
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/FileController.php+2 −2
- typo3/sysext/core/Classes/Resource/MetaDataAspect.php2+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php2+3 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+4 −4
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/AbstractFileCest.phpnew+70 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/FileClipboardCest.phpnew+96 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/FileOperationsCest.php+20 −11
- typo3/sysext/core/Tests/Acceptance/Fixtures/Images/blue_mountains.jpgnew+0 −0
- typo3/sysext/filelist/Classes/FileList.php2+16 −12
- typo3/sysext/impexp/Classes/Controller/ExportController.php2+5 −5
- typo3/sysext/impexp/Classes/Export.php+7 −7
- typo3/sysext/impexp/Classes/ImportExport.php4+24 −18
Review log 2029
Show 34 earlier messages
-
Jochen Roth uploaded patch set 1 07/09/21, 11:51
-
core-ci voted on patch set 1 V +1 07/09/21, 12:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13140
-
Benni Mack uploaded patch set 2 07/09/21, 12:33
-
Benni Mack voted on patch set 2 V +1 CR +1 07/09/21, 12:33
-
core-ci voted on patch set 2 V +1 07/09/21, 12:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13145
-
Oli Bartsch commented on patch set 2 CR -1 07/09/21, 13:30
I wonder what the changes in EXT:impexp have to do with the filelist. If this is intended, please let's explain this in the commit message.MetaDataAspect.php:104Why do we use an empty string instead of null?ExtendedFileUtility.php:1147Could we use strict comparison here or simply cast it to a bool directly? $keepFileName = (bool)($cmdArr['keepFilename'] ?? false);GeneralUtility.php:1411Could be casted to a bool.FileList.php:782UnresolvedDoes it even make sense to generate the url with an invalid uid?FileList.php:1017UnresolvedDoes it even make sense to generate the url with an invalid uid?ExportController.php:448canBeInterpretedAsInteger has a guard clause which check the given value for empty string, object and array. Therefore, I would suggest to use one of these as fallback, to make use of the guard clause. Preferably the empty string.ImportExport.php:408Could still be possible that $GLOBALS['TCA']['pages']['ctrl']['enablecolumns']['disabled'] is not set $this->dat['records'][$table . ':' . $uid]['data'], which would then still lead to a warning in PHP 8.ImportExport.php:695Could we please wrap those with parentheses. -
Jochen Roth uploaded patch set 3 07/09/21, 22:35
-
core-ci voted on patch set 3 V -1 07/09/21, 22:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13169
-
Jochen Roth rebased onto patch set 4 07/12/21, 07:17
-
core-ci voted on patch set 4 V -1 07/12/21, 07:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13200
-
Jochen Roth uploaded patch set 5 07/12/21, 07:36
-
core-ci voted on patch set 5 V +1 07/12/21, 07:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13203
-
Jochen Roth commented on patch set 5 07/12/21, 07:54
MetaDataAspect.php:104ReplyAckExtendedFileUtility.php:1147ReplyAckGeneralUtility.php:1411ReplyDoneExportController.php:448ReplyAckImportExport.php:408ReplyAckImportExport.php:695ReplyAck -
Benni Mack voted on patch set 5 V +1 CR +1 07/12/21, 08:24
-
Oli Bartsch commented on patch set 5 CR -1 07/12/21, 11:31
On it -
Oli Bartsch rebased onto patch set 6 07/12/21, 11:32
-
core-ci voted on patch set 6 V +1 07/12/21, 11:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13224
-
Oli Bartsch uploaded patch set 7 07/12/21, 12:55
-
core-ci voted on patch set 7 V +1 07/12/21, 13:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13235
-
Oli Bartsch voted on patch set 7 V +1 CR +1 07/12/21, 13:08
-
Benni Mack uploaded patch set 8 07/12/21, 14:58
-
core-ci voted on patch set 8 V +1 07/12/21, 15:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13247
-
Benni Mack voted on patch set 8 V +1 CR +1 07/12/21, 15:15
-
Jochen Roth voted on patch set 8 V +1 CR +1 07/12/21, 15:32
-
Oli Bartsch uploaded patch set 9 07/12/21, 16:55
-
Oli Bartsch voted on patch set 9 V +1 CR +1 07/12/21, 16:55
-
core-ci voted on patch set 9 V +1 07/12/21, 17:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13251
-
Benni Mack voted on patch set 9 V +2 CR +2 07/12/21, 17:44
-
Benni Mack merged patch set 10 07/12/21, 17:44