Review 10.4 Merged

69776[BUGFIX] Remove always true part of if condition

Benni Mack CR +2 V +2 Easy +6 −15 updated 07/12/21, 14:40

Commit message

This patch fixes several small bugs regarding DataHandler range
validation:

1. The strict comparison of the value against the default value might
compare floats with integer values. This causes the condition to be
always true. Besides of that, it's not smart to skip range validation
if the value equals the default value as the default value itself can
be out of range due to user error.

2. The TCA option "checkbox" for fields of type "input" is not used
anymore since TYPO3 4.5. This can be safely removed as the todo stated.

3. The tests for range validation with values evaluated as type double
used an incorrect eval value: "double". The correct value is "double2".
Tests are fixed according to that.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 07/12/21, 11:36

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 07/12/21, 11:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13226

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/12/21, 14:17

  4. Benni Mack rebased onto patch set 2 07/12/21, 14:17

  5. core-ci voted on patch set 2 V +1 07/12/21, 14:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13242

  6. Benni Mack voted on patch set 2 V +2 CR +2 07/12/21, 14:40

  7. Benni Mack merged patch set 3 07/12/21, 14:40