Review main Merged

69779[BUGFIX] Revert "Always override new request arguments when forwarding"

Benni Mack CR +2 V +2 Easy +3 −1 updated 07/13/21, 07:52

Commit message

This reverts commit 5932bdbd91f0127b89d639799043ac8e8c2f482b.
from https://review.typo3.org/c/Packages/TYPO3.CMS/+/69680

This change breaks regular forwarding of actions where
the original request actually had arguments, which are now
lost. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/69680

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 07/13/21, 07:37

  2. Oliver Hader voted on patch set 1 V +1 CR +1 07/13/21, 07:40

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 07/13/21, 07:51

  4. core-ci voted on patch set 1 V +1 07/13/21, 07:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13270

  5. Benni Mack voted on patch set 1 V +2 CR +2 07/13/21, 07:52

  6. Benni Mack merged patch set 2 07/13/21, 07:52