69792[TASK] Improve exception messages in ImageService
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Oli Bartsch uploaded patch set 1 07/09/21, 12:09
-
core-ci voted on patch set 1 V +1 07/09/21, 12:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13141
-
Andreas Kienast commented on patch set 1 CR -1 07/09/21, 13:00
-
Oli Bartsch commented on patch set 1 07/09/21, 13:34
ImageService.php:139ReplyACK, thought FileReference is defined as return type. However it's only annotated in the PHPdoc. Good catch, will update. -
Oli Bartsch uploaded patch set 2 07/09/21, 14:05
-
Oli Bartsch commented on patch set 2 07/09/21, 14:06
ImageService.php:139ReplyDone -
core-ci voted on patch set 2 V +1 07/09/21, 14:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13151
-
Jochen Roth voted on patch set 2 V +1 CR +1 07/12/21, 14:33
-
Benni Mack voted on patch set 2 V +1 CR +1 07/12/21, 14:54
-
Oli Bartsch voted on patch set 2 V +2 CR +2 07/12/21, 17:00
-
Oli Bartsch merged patch set 3 07/12/21, 17:00
ImageService.php:139