69794[BUGFIX] Rename recordlist export functionality to "download"
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 19
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/RecordDownloadButton.tsrenamed+13 −13
- typo3/sysext/core/Documentation/Changelog/master/Feature-94411-RecordlistDownloadSettings.rstnew+48 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-94411-RecordlistExportSettings.rstdeleted+0 −48
- typo3/sysext/core/Tests/Acceptance/Backend/RecordList/RecordDownloadCest.phprenamed+9 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordDownloadController.phprenamed+36 −37
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+20 −20
- typo3/sysext/recordlist/Classes/RecordList/DownloadRecordList.phprenamed+4 −4
- typo3/sysext/recordlist/Configuration/Backend/AjaxRoutes.php+3 −3
- typo3/sysext/recordlist/Configuration/Backend/Routes.php+3 −3
- typo3/sysext/recordlist/Configuration/Services.yaml+1 −1
- typo3/sysext/recordlist/Resources/Private/Language/locallang_download.xlfnew+110 −0
- typo3/sysext/recordlist/Resources/Private/Language/locallang_export.xlfdeleted+0 −113
- typo3/sysext/recordlist/Resources/Private/Templates/RecordDownloadSettings.htmlrenamed+23 −23
- typo3/sysext/recordlist/Resources/Public/JavaScript/RecordDownloadButton.jsnew+13 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/RecordExportButton.jsdeleted+0 −13
- typo3/sysext/recordlist/Tests/Functional/RecordList/DownloadRecordListTest.phprenamed+8 −8
Review log 810
-
Benni Mack uploaded patch set 1 07/09/21, 12:19
-
core-ci voted on patch set 1 V +1 07/09/21, 12:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13143
-
Andreas Kienast voted on patch set 1 V +1 CR +1 07/09/21, 12:54
-
Benni Mack commented on patch set 1 07/09/21, 12:55
We might want to change both the option names, and label to "download"? -
Oli Bartsch commented on patch set 1 07/09/21, 12:56
Reply
+1 for changing the label, too. -
Oli Bartsch uploaded patch set 2 07/09/21, 14:59
-
core-ci voted on patch set 2 V +1 07/09/21, 15:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13156
-
Jochen Roth voted on patch set 2 V +1 CR +1 07/09/21, 15:45
-
Benni Mack voted on patch set 2 V +2 CR +2 07/09/21, 16:03
-
Benni Mack merged patch set 3 07/09/21, 16:03